-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cnf network: fix test issues #372
Conversation
ajaggapa
commented
Jan 21, 2025
•
edited
Loading
edited
- Parallel Draining: Added NAD creation checkpoint to prevent flaky issues
- Sriov Metrics Exporter: Use VendorID instead of DeviceID (as it failed on cluster14)
- Rdma metrics API: Specific error messages added. eco-goinfra PR for CleanObjects is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 minor comment
@@ -122,9 +123,9 @@ var _ = Describe("rdmaMetricsAPI", Ordered, Label(tsparams.LabelRdmaMetricsAPITe | |||
|
|||
AfterEach(func() { | |||
By("Cleaning test namespace") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the comment
netparam.DefaultTimeout, pod.GetGVR()) | ||
Expect(err).ToNot(HaveOccurred(), "Failed to clean test namespace") | ||
By("Delete test pod") | ||
_, err := testPod.DeleteAndWait(1 * time.Minute) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you dont want to use the netparam timer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@evgenLevin @gkopels |