Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cnf network: fix test issues #372

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

ajaggapa
Copy link
Collaborator

@ajaggapa ajaggapa commented Jan 21, 2025

  • Parallel Draining: Added NAD creation checkpoint to prevent flaky issues
  • Sriov Metrics Exporter: Use VendorID instead of DeviceID (as it failed on cluster14)
  • Rdma metrics API: Specific error messages added. eco-goinfra PR for CleanObjects is merged.

evgenLevin
evgenLevin previously approved these changes Jan 21, 2025
Copy link
Collaborator

@evgenLevin evgenLevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor comment

@@ -122,9 +123,9 @@ var _ = Describe("rdmaMetricsAPI", Ordered, Label(tsparams.LabelRdmaMetricsAPITe

AfterEach(func() {
By("Cleaning test namespace")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the comment

evgenLevin
evgenLevin previously approved these changes Jan 21, 2025
netparam.DefaultTimeout, pod.GetGVR())
Expect(err).ToNot(HaveOccurred(), "Failed to clean test namespace")
By("Delete test pod")
_, err := testPod.DeleteAndWait(1 * time.Minute)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you dont want to use the netparam timer?

@ajaggapa ajaggapa changed the title cnf network: update RDMA Metrics API Tests cnf network: fix test issues Jan 27, 2025
evgenLevin
evgenLevin previously approved these changes Jan 27, 2025
Copy link
Collaborator

@evgenLevin evgenLevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ajaggapa
Copy link
Collaborator Author

@evgenLevin @gkopels
eco-goinfra dep bump is already completed for main branch with another PR. So dropped the bump commit.
Please review again.

@evgenLevin evgenLevin merged commit 3666b2f into openshift-kni:main Jan 31, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants