Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.18] infra: sriov git submodule should point to main #2160

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #2152

/assign zeeke

Main sriov-network-operator branch has moved from `master` to `main`.

Update the `SRIOV_NETWORK_OPERATOR_TARGET_COMMIT` variable accordingly to
fix errors like [1]:

```
+ cd ../sriov-network-operator/
+ git fetch --all
+ git checkout origin/master
error: pathspec 'origin/master' did not match any file(s) known to git
make: *** [Makefile:140: init-git-submodules] Error 1
```

[1] https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift-kni_cnf-features-deploy/2148/pull-ci-openshift-kni-cnf-features-deploy-master-e2e-aws-ci-tests/1877360047533592576

Signed-off-by: Andrea Panattoni <[email protected]>
@Tal-or
Copy link
Contributor

Tal-or commented Jan 14, 2025

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2025
@zeeke
Copy link
Member

zeeke commented Jan 14, 2025

/approve

Copy link
Contributor

openshift-ci bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, Tal-or, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2025
@zeeke
Copy link
Member

zeeke commented Jan 14, 2025

/cherrypick release-4.17

@openshift-cherrypick-robot
Copy link
Author

@zeeke: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zeeke
Copy link
Member

zeeke commented Jan 14, 2025

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit de155ed into openshift-kni:release-4.18 Jan 14, 2025
6 checks passed
@openshift-cherrypick-robot
Copy link
Author

@zeeke: new pull request created: #2162

In response to this:

/cherrypick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants