Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: sriov git submodule should point to main #2152

Merged

Conversation

zeeke
Copy link
Member

@zeeke zeeke commented Jan 10, 2025

Main sriov-network-operator branch has moved from master to main.

Update the SRIOV_NETWORK_OPERATOR_TARGET_COMMIT variable accordingly to fix errors like [1]:

+ cd ../sriov-network-operator/
+ git fetch --all
+ git checkout origin/master
error: pathspec 'origin/master' did not match any file(s) known to git
make: *** [Makefile:140: init-git-submodules] Error 1

[1] https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift-kni_cnf-features-deploy/2148/pull-ci-openshift-kni-cnf-features-deploy-master-e2e-aws-ci-tests/1877360047533592576

cc @SchSeba @sshnaidm

Main sriov-network-operator branch has moved from `master` to `main`.

Update the `SRIOV_NETWORK_OPERATOR_TARGET_COMMIT` variable accordingly to
fix errors like [1]:

```
+ cd ../sriov-network-operator/
+ git fetch --all
+ git checkout origin/master
error: pathspec 'origin/master' did not match any file(s) known to git
make: *** [Makefile:140: init-git-submodules] Error 1
```

[1] https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift-kni_cnf-features-deploy/2148/pull-ci-openshift-kni-cnf-features-deploy-master-e2e-aws-ci-tests/1877360047533592576

Signed-off-by: Andrea Panattoni <[email protected]>
@openshift-ci openshift-ci bot requested review from kenyis and SchSeba January 10, 2025 09:55
Copy link
Contributor

openshift-ci bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2025
@sshnaidm
Copy link
Contributor

/test e2e-telco5g-cnftests

Copy link
Contributor

openshift-ci bot commented Jan 10, 2025

@zeeke: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-telco5g-cnftests 96b4efa link false /test e2e-telco5g-cnftests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sshnaidm
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2025
@sshnaidm
Copy link
Contributor

/pj-rehearse ack

@openshift-merge-bot openshift-merge-bot bot merged commit 413a53d into openshift-kni:master Jan 10, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants