-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditionally change where avatar shows up #2082
Conditionally change where avatar shows up #2082
Conversation
The unit-test failures are due to OSD's mock of uiSettings incorrectly doesn't mock the start contract. This is fixed in opensearch-project/OpenSearch-Dashboards#7637. |
Changes look fine but seems like a unit test is failing |
Also update the tests to use good mocks for CoreStart Signed-off-by: Miki <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2082 +/- ##
==========================================
- Coverage 71.17% 71.04% -0.13%
==========================================
Files 96 96
Lines 2598 2604 +6
Branches 387 385 -2
==========================================
+ Hits 1849 1850 +1
Misses 649 649
- Partials 100 105 +5 ☔ View full report in Codecov by Sentry. |
e3da9b4
into
opensearch-project:main
Also update the tests to use good mocks for CoreStart Signed-off-by: Miki <[email protected]> Co-authored-by: Derek Ho <[email protected]> (cherry picked from commit e3da9b4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Also update the tests to use good mocks for CoreStart (cherry picked from commit e3da9b4) Signed-off-by: Miki <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Derek Ho <[email protected]>
Description
Reskins the account button and places it in the left nav when updated layout is used:
Also:
Category
Enhancement
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.