Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Conditionally change where avatar shows up #2088

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport e3da9b4 from #2082.

Also update the tests to use good mocks for CoreStart

Signed-off-by: Miki <[email protected]>
Co-authored-by: Derek Ho <[email protected]>
(cherry picked from commit e3da9b4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 71.04%. Comparing base (2b5028b) to head (6ec6eea).
Report is 1 commits behind head on 2.x.

Files Patch % Lines
public/apps/account/account-nav-button.tsx 40.00% 0 Missing and 3 partials ⚠️
public/apps/account/account-app.tsx 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #2088      +/-   ##
==========================================
- Coverage   71.17%   71.04%   -0.13%     
==========================================
  Files          96       96              
  Lines        2598     2604       +6     
  Branches      380      392      +12     
==========================================
+ Hits         1849     1850       +1     
  Misses        649      649              
- Partials      100      105       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@derek-ho derek-ho merged commit 406d169 into 2.x Aug 16, 2024
32 of 34 checks passed
@derek-ho derek-ho deleted the backport/backport-2082-to-2.x branch August 16, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants