Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make images responsive by default #2405

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Make images responsive by default #2405

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f4c964
Make images responsive by default
kolchfa-aws Nov 1, 2023
750f8ae
Make only images inside blogs responsive
kolchfa-aws Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions _sass/_opensearch.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ $max-container: 1440px;
.author-photo {
width: 180px;
height: auto;
border: none;
}


Expand All @@ -193,17 +194,20 @@ $max-container: 1440px;
}
}

.img-fluid {
img {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kolchfa-aws This selector is a type selector that will target all images everywhere regardless of location in the docuement. If the goal is to affect images within the content without needing to apply the Kramdown extension for applying the .img-fluid class then I might suggest that the selector be more deliberate, and nested within the selector for the parent of the content as to prevent unforseen consequences with affecting images anywhere on the site that might appear now, or in the future without needing to override if at all necessary. For example Blog post content is interpolated into the #content-main element.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @astephanus! Let me correct that.

max-width: 100%;
height: auto;
border: 1px solid $line-lighter;
}

.img-fluid {
height: auto;
}

.img-centered {
max-width: 100%;
margin: 0 auto;
display: block;
border: 1px solid $line-lighter;
}

.downloads-page {
.layout-2col {
.col {
Expand Down