Make images responsive by default #2405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fanit Kolchina <[email protected]>
kolchfa-aws
requested review from
elfisher,
AMoo-Miki,
nknize,
krisfreedain,
peterzhuamazon,
CEHENKLE,
dtaivpp and
nateynateynate
as code owners
ghost
reviewed
Nov 1, 2023
_sass/_opensearch.scss
Outdated
| @@ -193,17 +194,20 @@ $max-container: 1440px; | |||
| } | |||
| } | |||
|
|
|||
| .img-fluid { | |||
| img { | |||
There was a problem hiding this comment.
@kolchfa-aws This selector is a type selector that will target all images everywhere regardless of location in the docuement. If the goal is to affect images within the content without needing to apply the Kramdown extension for applying the .img-fluid class then I might suggest that the selector be more deliberate, and nested within the selector for the parent of the content as to prevent unforseen consequences with affecting images anywhere on the site that might appear now, or in the future without needing to override if at all necessary. For example Blog post content is interpolated into the #content-main element.
There was a problem hiding this comment.
Thanks, @astephanus! Let me correct that.
Signed-off-by: Fanit Kolchina <[email protected]>
nateynateynate
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make images responsive by default
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.