-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 1.3.0 release notes in main #2489
Add 1.3.0 release notes in main #2489
Conversation
✅ Gradle Check success 5c4318a334363d419b8d673882f30eb3d24506b2 |
I understand these were generated with a tool, but they are unreadable because of the garbage in the commit messages. Should we do a human pass on those first? @stockholmux @elfisher ? |
Yeah, @dblock, these don't look right and are a major departure from our previous format. |
Thanks @stockholmux for the review. I was following the same steps as for 1.2.0 release to generate the md file using Can you please share previous format you are referring here ? I will try to follow the same. |
Here are the release notes @dreamer-89 : https://github.com/opensearch-project/OpenSearch/tree/main/release-notes |
Thank you @owaiskazi19 for sharing the sample. @dblock @stockholmux : What do you suggest ? |
So when I compare the release notes of 1.2.0 to these, I'm seeing a lot more that looks like it's generated by a machine - for example, a lot of 'bump' generated by dependabot and the autogenerated email accounts (e.g. 49699333+dependabot[bot]@users.noreply.github.com) |
Thanks @stockholmux for the prompt response. I see there was a recent change, on Feb 17th where we did dependabot integration in OpenSearch repository. Dependabot updates the new version of dependencies automatically and currently runs on weekly basis. If you feel these commits, don't add value in release notes, I can remove these. |
@dreamer-89 I think that would go a long way. @dblock Thoughts? |
Definitely. I would hand-edit the notes the be useful to humans as much as needed. I also have #1868 opened that could be a solution to this problem moving forward. |
@stockholmux @dblock : I updated the release notes. Kindly review |
❌ Gradle Check failure 69ed0bf6ce16fccd937727ff7b1e85facc8e5d36 |
❌ Gradle Check failure 95b6151081f5e5264559ceabe6cedea8a9997033 |
Signed-off-by: Suraj Singh <[email protected]>
…n, linings, incorrect blocks Signed-off-by: Suraj Singh <[email protected]>
Signed-off-by: Suraj Singh <[email protected]>
95b6151
to
dd8f43c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
start gradle check |
|
start gradle check |
Signed-off-by: Suraj Singh [email protected]
Description
Adds 1.3 release notes starting from 1.x version bump to 1.3.
Issues Resolved
#2257
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.