Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the release notes for 1.3.0 release #1766

Merged
merged 2 commits into from
Mar 17, 2022

Conversation

zelinh
Copy link
Member

@zelinh zelinh commented Mar 16, 2022

Signed-off-by: Zelin Hao [email protected]

Description

Add the release notes for 1.3.0 release which combines the notes from core and plugins.

Issues Resolved

part of #889

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@zelinh zelinh requested a review from a team as a code owner March 16, 2022 23:12
@zelinh
Copy link
Member Author

zelinh commented Mar 16, 2022

The PR for release notes of core is raised here: opensearch-project/OpenSearch#2489.
I put the potential link in the certain section of this PR.

@@ -0,0 +1,632 @@
# OpenSearch and Dashboards 1.3.0 Release Notes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add release highlights for ml-commons?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added a brief line saying ml-commons now becomes part of the release. Any other recommendations about what to say here?

release-notes/opensearch-release-notes-1.3.0.md Outdated Show resolved Hide resolved

### Opensearch Ml Common
* Bump version to 1.2 ([#90](https://github.com/opensearch-project/ml-commons/pull/90))
* bump to 1.2.3 ([#110](https://github.com/opensearch-project/ml-commons/pull/110))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have 1.2.3 PR here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I was confused initially as well. Seems like it's what was included in the notes from ml-commons. https://github.com/opensearch-project/ml-commons/blob/main/release-notes/opensearch-ml-common.release-notes-1.3.0.0.md#maintenance.
Could you help confirm it? @Zhangxunmt Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We got message that we should include all PRs in our release notes, that's why we include this one. Should we remove it? Is it ok to just remove from this release note, otherwise we need a new PR to merge into 1.3

Copy link
Member

@stockholmux stockholmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • A few small changes regarding ml commons
  • At a higher level, the categorization seems to be a little off. As an example, there is a lot of commits related to auto backport and they're spread throughout the different categories on different repos. Should this be all infrastructure?

release-notes/opensearch-release-notes-1.3.0.md Outdated Show resolved Hide resolved
release-notes/opensearch-release-notes-1.3.0.md Outdated Show resolved Hide resolved
release-notes/opensearch-release-notes-1.3.0.md Outdated Show resolved Hide resolved
release-notes/opensearch-release-notes-1.3.0.md Outdated Show resolved Hide resolved
release-notes/opensearch-release-notes-1.3.0.md Outdated Show resolved Hide resolved
release-notes/opensearch-release-notes-1.3.0.md Outdated Show resolved Hide resolved
release-notes/opensearch-release-notes-1.3.0.md Outdated Show resolved Hide resolved
### OpenSearch Performance Analyzer
* Add .whitesource configuration file ([#119](https://github.com/opensearch-project/performance-analyzer/pull/119))
* Add support for OPENSEARCH_JAVA_HOME ([#133](https://github.com/opensearch-project/performance-analyzer/pull/133))
* Adding auto backport ([#146](https://github.com/opensearch-project/performance-analyzer/pull/146))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where should this go? Anything with workflows should not be considered new features but rather infrastructure.

(most of this section here, actually)

@codecov-commenter
Copy link

Codecov Report

Merging #1766 (a35ff31) into main (4a537b7) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1766   +/-   ##
=========================================
  Coverage     94.68%   94.68%           
  Complexity       18       18           
=========================================
  Files           171      171           
  Lines          3554     3554           
  Branches         27       27           
=========================================
  Hits           3365     3365           
  Misses          185      185           
  Partials          4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a537b7...a35ff31. Read the comment docs.

Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalize first letter of each line

* Adding auto backport ([#146](https://github.com/opensearch-project/performance-analyzer/pull/146))


### OpenSearch Sql
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change everywhere : sql -> SQL

* Adds support on UI for min primary shard size rollover condition and min rollover age transition condition ([#159](https://github.com/opensearch-project/index-management-dashboards-plugin/pull/159))


### OpenSearch Knn
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change everywhere : knn -> k-NN

## Release Highlights

### OpenSearch Ml Commons
* ml-commons now officially becomes part of the OpenSearch 1.3.0 release.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ml-commons is a new plugin built from scratch, it's not any forked code. I know there is https://mlcommons.org/en/, but this OpenSearch ml-commons plugin is different. How about we tune the word as we released a new ML plugin providing common machine learning algorithms? Tech writer may help here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. We might need rephrase the words more properly

Copy link

@Naarcha-AWS Naarcha-AWS Mar 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could say something like, "The new ML Commons plugin empowers users to train and apply machine learning models as a part of the OpenSearch 1.3.0 release".

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zelinh please make a follow up PR to address the callouts.

Thanks.

@peterzhuamazon peterzhuamazon dismissed stockholmux’s stale review March 17, 2022 18:03

We will have a 2nd PR to address the callouts.

@peterzhuamazon peterzhuamazon merged commit da4a6d3 into opensearch-project:main Mar 17, 2022
@peterzhuamazon peterzhuamazon deleted the release-notes branch March 17, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants