-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the release notes for 1.3.0 release #1766
Conversation
Signed-off-by: Zelin Hao <[email protected]>
The PR for release notes of core is raised here: opensearch-project/OpenSearch#2489. |
@@ -0,0 +1,632 @@ | |||
# OpenSearch and Dashboards 1.3.0 Release Notes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add release highlights for ml-commons?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added a brief line saying ml-commons now becomes part of the release. Any other recommendations about what to say here?
|
||
### Opensearch Ml Common | ||
* Bump version to 1.2 ([#90](https://github.com/opensearch-project/ml-commons/pull/90)) | ||
* bump to 1.2.3 ([#110](https://github.com/opensearch-project/ml-commons/pull/110)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have 1.2.3 PR here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I was confused initially as well. Seems like it's what was included in the notes from ml-commons. https://github.com/opensearch-project/ml-commons/blob/main/release-notes/opensearch-ml-common.release-notes-1.3.0.0.md#maintenance.
Could you help confirm it? @Zhangxunmt Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We got message that we should include all PRs in our release notes, that's why we include this one. Should we remove it? Is it ok to just remove from this release note, otherwise we need a new PR to merge into 1.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- A few small changes regarding ml commons
- At a higher level, the categorization seems to be a little off. As an example, there is a lot of commits related to auto backport and they're spread throughout the different categories on different repos. Should this be all infrastructure?
### OpenSearch Performance Analyzer | ||
* Add .whitesource configuration file ([#119](https://github.com/opensearch-project/performance-analyzer/pull/119)) | ||
* Add support for OPENSEARCH_JAVA_HOME ([#133](https://github.com/opensearch-project/performance-analyzer/pull/133)) | ||
* Adding auto backport ([#146](https://github.com/opensearch-project/performance-analyzer/pull/146)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where should this go? Anything with workflows should not be considered new features but rather infrastructure.
(most of this section here, actually)
Signed-off-by: Zelin Hao <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1766 +/- ##
=========================================
Coverage 94.68% 94.68%
Complexity 18 18
=========================================
Files 171 171
Lines 3554 3554
Branches 27 27
=========================================
Hits 3365 3365
Misses 185 185
Partials 4 4 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalize first letter of each line
* Adding auto backport ([#146](https://github.com/opensearch-project/performance-analyzer/pull/146)) | ||
|
||
|
||
### OpenSearch Sql |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change everywhere : sql -> SQL
* Adds support on UI for min primary shard size rollover condition and min rollover age transition condition ([#159](https://github.com/opensearch-project/index-management-dashboards-plugin/pull/159)) | ||
|
||
|
||
### OpenSearch Knn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change everywhere : knn -> k-NN
## Release Highlights | ||
|
||
### OpenSearch Ml Commons | ||
* ml-commons now officially becomes part of the OpenSearch 1.3.0 release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ml-commons
is a new plugin built from scratch, it's not any forked code. I know there is https://mlcommons.org/en/, but this OpenSearch ml-commons
plugin is different. How about we tune the word as we released a new ML plugin providing common machine learning algorithms? Tech writer may help here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. We might need rephrase the words more properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could say something like, "The new ML Commons plugin empowers users to train and apply machine learning models as a part of the OpenSearch 1.3.0 release".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zelinh please make a follow up PR to address the callouts.
Thanks.
We will have a 2nd PR to address the callouts.
Signed-off-by: Zelin Hao [email protected]
Description
Add the release notes for 1.3.0 release which combines the notes from core and plugins.
Issues Resolved
part of #889
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.