Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing the ondatra verison to v0.7.0 #3747

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
+53 −2,211
Open

fixing the ondatra verison to v0.7.0 #3747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
0c4eed0
fixing the ondatra verison to v0.7.0
ram-mac Feb 4, 2025
8137994
fixed version
ram-mac Feb 4, 2025
2b34204
fixed the go.sum error
ram-mac Feb 4, 2025
92fd4c8
fixed actions_MED_LocPref_prepend_flow_control_test with set-med-acti…
ram-mac Feb 4, 2025
f5b0062
fixing the action while setting med
ram-mac Feb 4, 2025
bc09c83
fixing the string
ram-mac Feb 4, 2025
fb9a735
fixed string to convert to int32 as string is not supported anymore
ram-mac Feb 4, 2025
f17ea29
fixed Union int32
ram-mac Feb 4, 2025
77e44e0
fixing the go version to 1.22.0
ram-mac Feb 4, 2025
d5adc93
fixed go version to 1.23.4
ram-mac Feb 4, 2025
bb04cd1
fixing gribi version
ram-mac Feb 5, 2025
1599c6c
fixing gribi version
ram-mac Feb 5, 2025
8eb8879
fixing git.sum gribi checksum
ram-mac Feb 5, 2025
0820695
fixing ygot version to v0.13.2/go.mod h1:kJN0yCXIH07dOXvNBEFm3XxXdnDD…
ram-mac Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/go.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@424fc82d43fa5a37540bae62709ddcc23d9520d4
with:
go-version: 1.21.x
go-version: 1.23.x
- name: Cache
uses: actions/cache@704facf57e6136b1bc63b828d79edcd491f0ee84
with:
Expand All @@ -32,7 +32,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@424fc82d43fa5a37540bae62709ddcc23d9520d4
with:
go-version: 1.21.x
go-version: 1.23.x
- name: Cache
uses: actions/cache@f4b3439a656ba812b8cb417d2d49f9c810103092
with:
Expand All @@ -55,7 +55,7 @@ jobs:
- name: Install go
uses: actions/setup-go@424fc82d43fa5a37540bae62709ddcc23d9520d4
with:
go-version: '1.21'
go-version: '1.23'
# Go & staticcheck build cache require a lot of disk space. Reclaim extra
# space for the container by removing unnecessary tooling.
- name: Free additional disk space
Expand Down
5 changes: 4 additions & 1 deletion ...tions_med_localpref_prepend_flow_control/actions_MED_LocPref_prepend_flow_control_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,12 +259,15 @@ func configureASLocalPrefMEDPolicy(t *testing.T, dut *ondatra.DUTDevice, policyT
t.Fatalf("BgpSetMedV7Unsupported deviation needs cli configuration for vendor %s which is not defined", dut.Vendor())
}
} else {
actions.GetOrCreateBgpActions().SetMed = oc.UnionString(policyValue)
metric, _ := strconv.Atoi(policyValue)
actions.GetOrCreateBgpActions().SetMed = oc.UnionUint32(uint32(metric))
actions.GetOrCreateBgpActions().SetMedAction = oc.BgpPolicy_BgpSetMedAction_SET
actions.PolicyResult = oc.RoutingPolicy_PolicyResultType_ACCEPT_ROUTE
}
} else {
metric, _ := strconv.Atoi(policyValue)
actions.GetOrCreateBgpActions().SetMed = oc.UnionUint32(uint32(metric))
actions.GetOrCreateBgpActions().SetMedAction = oc.BgpPolicy_BgpSetMedAction_SET
actions.PolicyResult = oc.RoutingPolicy_PolicyResultType_ACCEPT_ROUTE
}
case setPrependPolicy:
Expand Down
32 changes: 16 additions & 16 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,39 +1,39 @@
module github.com/openconfig/featureprofiles

go 1.22.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't change keep the go version;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if i do not change the go version i get a lot of errors and most of the checks are failing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The errors from the static_analysis shows below
github.com/openconfig/[email protected] requires go >= 1.23.4 (running go 1.22.0)

go 1.23.4

require (
cloud.google.com/go/pubsub v1.36.1
cloud.google.com/go/storage v1.38.0
github.com/cisco-open/go-p4 v0.1.2
github.com/go-git/go-billy/v5 v5.6.0
github.com/go-git/go-git/v5 v5.13.0
github.com/golang/glog v1.2.2
github.com/golang/glog v1.2.3
github.com/google/go-cmp v0.6.0
github.com/google/go-github/v50 v50.1.0
github.com/google/gopacket v1.1.19
github.com/google/uuid v1.6.0
github.com/grpc-ecosystem/go-grpc-middleware v1.4.0
github.com/kr/pretty v0.3.1
github.com/open-traffic-generator/snappi/gosnappi v1.3.0
github.com/open-traffic-generator/snappi/gosnappi v1.17.1
github.com/openconfig/containerz v0.0.0-20250119143156-ea1f112cd31c
github.com/openconfig/entity-naming v0.0.0-20250108173956-784f643e8b64
github.com/openconfig/gnmi v0.11.0
github.com/openconfig/gnoi v0.6.0
github.com/openconfig/gnoigo v0.0.0-20240320202954-ebd033e3542c
github.com/openconfig/gnoigo v0.0.0-20240820205259-23ac4e061cc2
github.com/openconfig/gnsi v1.7.0
github.com/openconfig/gocloser v0.0.0-20220310182203-c6c950ed3b0b
github.com/openconfig/goyang v1.4.5
github.com/openconfig/goyang v1.6.0
github.com/openconfig/gribi v1.0.0
github.com/openconfig/gribigo v0.0.0-20240829231637-69cf06726cc3
github.com/openconfig/kne v0.1.18
github.com/openconfig/models-ci v1.0.2-0.20231113233730-f0986391428e
github.com/openconfig/ondatra v0.6.1
github.com/openconfig/ondatra v0.7.1
github.com/openconfig/replayer v0.0.0-20240110192655-4e9cf83d8d30
github.com/openconfig/testt v0.0.0-20220311054427-efbb1a32ec07
github.com/openconfig/ygnmi v0.11.1
github.com/openconfig/ygot v0.29.19
github.com/p4lang/p4runtime v1.4.0-rc.5.0.20220728214547-13f0d02a521e
github.com/openconfig/ygot v0.29.20
github.com/p4lang/p4runtime v1.4.1
github.com/pborman/uuid v1.2.1
github.com/protocolbuffers/txtpbfmt v0.0.0-20220608084003-fc78c767cd6a
github.com/spf13/cobra v1.8.1
Expand All @@ -42,7 +42,7 @@ require (
github.com/yoheimuta/go-protoparser/v4 v4.9.0
github.com/yuin/goldmark v1.4.13
golang.org/x/crypto v0.32.0
golang.org/x/exp v0.0.0-20240719175910-8a7402abbf56
golang.org/x/exp v0.0.0-20241210194714-1829a127f884
golang.org/x/text v0.21.0
google.golang.org/api v0.171.0
google.golang.org/grpc v1.69.4
Expand All @@ -53,7 +53,7 @@ require (
)

require (
github.com/Masterminds/semver/v3 v3.2.1 // indirect
github.com/Masterminds/semver/v3 v3.3.1 // indirect
github.com/Microsoft/go-winio v0.6.1 // indirect
golang.org/x/oauth2 v0.23.0
)
Expand Down Expand Up @@ -83,7 +83,7 @@ require (
github.com/envoyproxy/protoc-gen-validate v1.1.0 // indirect
github.com/evanphx/json-patch/v5 v5.6.0 // indirect
github.com/felixge/httpsnoop v1.0.4 // indirect
github.com/fsnotify/fsnotify v1.7.0 // indirect
github.com/fsnotify/fsnotify v1.8.0 // indirect
github.com/ghodss/yaml v1.0.0 // indirect
github.com/go-git/gcfg v1.5.1-0.20230307220236-3a3c6141e376 // indirect
github.com/go-logr/logr v1.4.2 // indirect
Expand All @@ -110,7 +110,7 @@ require (
github.com/kevinburke/ssh_config v1.2.0 // indirect
github.com/kr/text v0.2.0 // indirect
github.com/kylelemons/godebug v1.1.0 // indirect
github.com/magiconair/properties v1.8.7 // indirect
github.com/magiconair/properties v1.8.9 // indirect
github.com/mailru/easyjson v0.7.7 // indirect
github.com/mitchellh/go-wordwrap v1.0.1 // indirect
github.com/mitchellh/mapstructure v1.5.0 // indirect
Expand All @@ -126,7 +126,7 @@ require (
github.com/openconfig/grpctunnel v0.0.0-20220819142823-6f5422b8ca70 // indirect
github.com/openconfig/lemming/operator v0.2.0 // indirect
github.com/patrickmn/go-cache v2.1.0+incompatible // indirect
github.com/pelletier/go-toml/v2 v2.2.2 // indirect
github.com/pelletier/go-toml/v2 v2.2.3 // indirect
github.com/pjbgf/sha1cd v0.3.0 // indirect
github.com/pkg/errors v0.9.1 // indirect
github.com/planetscale/vtprotobuf v0.6.1-0.20240319094008-0393e58bdf10 // indirect
Expand All @@ -140,7 +140,7 @@ require (
github.com/skeema/knownhosts v1.3.0 // indirect
github.com/sourcegraph/conc v0.3.0 // indirect
github.com/spf13/afero v1.11.0 // indirect
github.com/spf13/cast v1.6.0 // indirect
github.com/spf13/cast v1.7.0 // indirect
github.com/srl-labs/srl-controller v0.6.1 // indirect
github.com/srl-labs/srlinux-scrapli v0.6.0 // indirect
github.com/subosito/gotenv v1.6.0 // indirect
Expand All @@ -154,13 +154,13 @@ require (
go.opentelemetry.io/otel/trace v1.34.0 // indirect
go.uber.org/atomic v1.11.0 // indirect
go.uber.org/multierr v1.11.0 // indirect
golang.org/x/mod v0.19.0 // indirect
golang.org/x/mod v0.22.0 // indirect
golang.org/x/net v0.34.0 // indirect
golang.org/x/sync v0.10.0 // indirect
golang.org/x/sys v0.29.0 // indirect
golang.org/x/term v0.28.0 // indirect
golang.org/x/time v0.9.0 // indirect
golang.org/x/tools v0.23.0 // indirect
golang.org/x/tools v0.28.0 // indirect
google.golang.org/genproto v0.0.0-20240227224415-6ceb2ff114de // indirect
google.golang.org/genproto/googleapis/api v0.0.0-20241015192408-796eee8c2d53 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20250115164207-1a7da9e5054f // indirect
Expand Down
Loading
Loading