fixing the ondatra verison to v0.7.0 #3747
Open
+56
−2,215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Functional Test Report for #3747 / ab9114aVirtual Devices
Hardware Devices
|
|
Initially i had changed only the ondatra version from 0.6.1 to 0.7.1 but it ran into multiple failures with respect to dependancies packages. |
self-maurya
reviewed
Feb 4, 2025
| @@ -1,39 +1,39 @@ | |||
| module github.com/openconfig/featureprofiles | |||
|
|
|||
| go 1.22.0 | |||
There was a problem hiding this comment.
don't change keep the go version;
There was a problem hiding this comment.
if i do not change the go version i get a lot of errors and most of the checks are failing.
There was a problem hiding this comment.
The errors from the static_analysis shows below
github.com/openconfig/[email protected] requires go >= 1.23.4 (running go 1.22.0)
…5NI6K99tnD5x49c= in go.sum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the Ondatra version to fix
PR3739 and PR3701