Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with collapsed metadata fieldset being hidden in JSON dump plugin #5091

Conversation

viktorvanwijk
Copy link
Contributor

@viktorvanwijk viktorvanwijk commented Feb 7, 2025

Closes #5088

Changes

Ensure overflow: visible is set for the metadata variables fieldset in the JSON Dump plugin

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.74%. Comparing base (a1a1b00) to head (c9e42ed).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5091   +/-   ##
=======================================
  Coverage   96.74%   96.74%           
=======================================
  Files         771      771           
  Lines       26636    26636           
  Branches     3467     3467           
=======================================
  Hits        25770    25770           
  Misses        605      605           
  Partials      261      261           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viktorvanwijk viktorvanwijk marked this pull request as draft February 7, 2025 10:46
@viktorvanwijk viktorvanwijk marked this pull request as ready for review February 10, 2025 10:48
@viktorvanwijk viktorvanwijk force-pushed the bug/5088-metadata-fieldset-in-json-registration-options-is-not-visible-when-lots-of-variables-are-selected branch from b0dc8ba to 93e272c Compare February 13, 2025 14:29
@viktorvanwijk viktorvanwijk changed the title Move metadata variable options to separate tab in JSON dump plugin Ensure collapsed metadata fieldset is always visible Feb 13, 2025
@viktorvanwijk viktorvanwijk changed the title Ensure collapsed metadata fieldset is always visible Fix bug with collapsed metadata fieldset being hidden in JSON dump plugin Feb 13, 2025
When a lot of variables are selected, the metadata fieldset gets pushed down in the modal. If it is collapsed, this causes it to disappear and not be accessible at all. The CSS styling for this collapsed class contains an `overflow: hidden` property that causes this.

This change adds a custom scss class openforms-fieldset, which overrides it to `overflow: visible`
@viktorvanwijk viktorvanwijk force-pushed the bug/5088-metadata-fieldset-in-json-registration-options-is-not-visible-when-lots-of-variables-are-selected branch from 93e272c to c9e42ed Compare February 13, 2025 14:33
@robinmolen robinmolen merged commit 06c301c into master Feb 13, 2025
33 checks passed
@robinmolen robinmolen deleted the bug/5088-metadata-fieldset-in-json-registration-options-is-not-visible-when-lots-of-variables-are-selected branch February 13, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Metadata fieldset in JSON registration options is not visible when lots of variables are selected
2 participants