-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata fieldset in JSON registration options is not visible when lots of variables are selected #5088
Labels
Comments
viktorvanwijk
added a commit
that referenced
this issue
Feb 7, 2025
… plugin options When a lot of variables are selected, the metadata fieldset gets pushed down in the modal. If it is collapsed, this causes it to disappear and not be accessible at all. The CSS styling for this collapsed class contains an `overflow: hidden` property that causes this. At this time, it seems difficult to override this styling in a .scss file, so as a (temporary) workaround it is moved to a separate tab.
10 tasks
10 tasks
viktorvanwijk
added a commit
that referenced
this issue
Feb 7, 2025
viktorvanwijk
added a commit
that referenced
this issue
Feb 7, 2025
Because the initial value of fixed metadata variables is set to an empty list and the fixed metadata variables field in the serializer was not set to read only, they would be overwritten when saving the form, resulting in a permanent empty list of fixed variables. This fix adds an API endpoint to fetch the default fixed variables dynamically in the frontend. This means they will be available directly when setting up the plugin for the first time.
viktorvanwijk
added a commit
that referenced
this issue
Feb 7, 2025
…ables table of JSON dump plugin If the JSON dump plugin was not completely initialized yet (selected but not saved), and the user navigated to the registration variables of the variables table, the backend options would be an empty object, causing a crash.
viktorvanwijk
added a commit
that referenced
this issue
Feb 10, 2025
Add test to confirm metadata fieldset is in the 'Extra' tab
viktorvanwijk
added a commit
that referenced
this issue
Feb 13, 2025
When a lot of variables are selected, the metadata fieldset gets pushed down in the modal. If it is collapsed, this causes it to disappear and not be accessible at all. The CSS styling for this collapsed class contains an `overflow: hidden` property that causes this. This change adds a custom scss class openforms-fieldset, which overrides it to `overflow: visible`
viktorvanwijk
added a commit
that referenced
this issue
Feb 13, 2025
When a lot of variables are selected, the metadata fieldset gets pushed down in the modal. If it is collapsed, this causes it to disappear and not be accessible at all. The CSS styling for this collapsed class contains an `overflow: hidden` property that causes this. This change adds a custom scss class openforms-fieldset, which overrides it to `overflow: visible`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When no variables are selected:
When lots of variables are selected:
Also, might be a good idea to make the variable selection component wider, to account for the number (and also name length) of the variables
The text was updated successfully, but these errors were encountered: