Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow-template for publishing Python project to PyPI #4

Merged
merged 3 commits into from
Oct 30, 2020

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Oct 28, 2020

Primarily inspired by the work on omero-cli-zarr this should make the standard publish to PyPI on tags workflow activatable at minimal cost across projects.

/cc @ome/python

Primarily inspired by the work on omero-cli-zarr this should make the
standard publish to PyPI on tags workflow activatable at minimal cost across
projects.
@joshmoore
Copy link
Member

Good to have beaten on this a bit via ome/omero-cli-zarr#37 and ome/omero-cli-zarr#41 😉

@sbesson
Copy link
Member Author

sbesson commented Oct 28, 2020

Also including ome/omero-cli-zarr@ec0bebd in the history.

Short version: this all started as an honorable attempt to create a template workflow implementing https://packaging.python.org/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/#publishing-the-distribution-to-pypi-and-testpypi but in practice ended up with a more simple but effective publishing of tags to PyPi.

@jburel
Copy link
Member

jburel commented Oct 29, 2020

Maybe a file like REFERENCES.md could be useful to capture link https://packaging.python.org/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/#publishing-the-distribution-to-pypi-and-testpypi in case one would like for example to use testpypi

@sbesson
Copy link
Member Author

sbesson commented Oct 29, 2020

Would this file be stored under workflow-templates ? Do you have an example somewhere we could inherit?
Otherwise, I can add a reference in the template itself if that's useful.

@jburel
Copy link
Member

jburel commented Oct 29, 2020

I don't have any example. I was thinking that it could be alongside of the readme and other files
I think it could become a list of references not only associate to workflow e.g. hack.md

@sbesson
Copy link
Member Author

sbesson commented Oct 29, 2020

Pushed f41ca70

@sbesson sbesson requested a review from jburel October 29, 2020 20:03
Copy link
Member

@jburel jburel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for capturing the reference

@jburel jburel merged commit 567ce80 into ome:master Oct 30, 2020
@sbesson sbesson deleted the pypi_template branch October 30, 2020 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants