-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate CI to GitHub actions #240
Conversation
- create GitHub workflow with 3 steps: install from source, test and publish - remove Travis-specific environment from tox.ini and use markers like omero-py - expand envlist to run tests under Python 3.7 and 3.8 - remove .travis.yml
In general, big 👍. I'd still like to see some for of re-use, but I'm failing to see an easy path forward where changes can be propagated:
|
To reuse this you'd probably want to split it into several github actions which do one thing, e.g. install standard dependencies, run standard scripts, a bit like https://github.com/ome/omero-test-infra but with one action per step (and with less coupling?) instead of bundling everything together. |
e9f540b
to
6c9021b
Compare
Folllowing the preliminary work on omero-cli-zarr and ome/.github#4, I went ahead and split the single workflow into 3 workflows. The PyPI publication should match the proposed template and I would assume the Tox one could also be turned into a template |
Relisting for a last round of comments and objections to merging this in the current state? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, big 👍. Some of the badges are hard to confirm until after this is merged, but certainly no objections to iterating through this. Thanks.
Largely inspired by the work in omero-py this migrates the CI to using GitHub actions and also adds coverage for Python 3.7 and 3.8