Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runtime: fix for OCaml.5.1.1 #1535

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Runtime: fix for OCaml.5.1.1 #1535

merged 1 commit into from
Nov 27, 2023

Conversation

hhugo
Copy link
Member

@hhugo hhugo commented Nov 27, 2023

fix #1534

@hhugo
Copy link
Member Author

hhugo commented Nov 27, 2023

@Octachron, the following two points are about the ocaml codebase:

  • no sure why caml_compression_available exists but is not used/exposed, is it a leftover ?
  • the return value of caml_zstd_initialize needs to be fixed.

@hhugo hhugo force-pushed the ocaml511 branch 2 times, most recently from cbd7548 to eaf25f9 Compare November 27, 2023 14:03
@Octachron
Copy link

  1. Yes, and it will be removed before the release (removing a primitive requires a bootstrap, moving it to the release allow to merge the release bootstrap with this one).
  2. Fixed upstream right now.

@hhugo hhugo merged commit a3be888 into master Nov 27, 2023
15 checks passed
@hhugo hhugo deleted the ocaml511 branch November 27, 2023 17:00
@kit-ty-kate kit-ty-kate mentioned this pull request Nov 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for OCaml 5.1.1
2 participants
@hhugo @Octachron