Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js_of_ocaml-compiler is not compatible with OCaml 5.1.1 #24870

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

kit-ty-kate
Copy link
Member

requires caml_zstd_initialize to be implemented in javascript.
Any usage of js_of_ocaml with OCaml 5.1.1 will fail

#=== ERROR while compiling jsonoo.0.1.0 =======================================#
# context              2.2.0~alpha3 | linux/x86_64 | ocaml-variants.5.1.1+trunk | file:///home/opam/opam-repository
# path                 ~/.opam/5.1.1/.opam-switch/build/jsonoo.0.1.0
# command              ~/.opam/5.1.1/bin/dune build -p jsonoo -j 1 @install @runtest
# exit-code            1
# env-file             ~/.opam/log/jsonoo-354-c54ecb.env
# output-file          ~/.opam/log/jsonoo-354-c54ecb.out
### output ###
# (cd _build/default && /home/opam/.opam/5.1.1/bin/ocamlc.opt -w -40 -g -bin-annot -I test/.test_jsonoo.eobjs/byte -I /home/opam/.opam/5.1.1/lib/js_of_ocaml -I /home/opam/.opam/5.1.1/lib/webtest -I /home/opam/.opam/5.1.1/lib/webtest-js -I .jsonoo.objs/byte -no-alias-deps -o test/.test_jsonoo.eobjs/byte/dune__exe__Test_jsonoo.cmo -c -impl test/test_jsonoo.ml)
# File "test/test_jsonoo.ml", line 528, characters 27-38:
# 528 |       (fun () -> ignore @@ (at []) int);
#                                  ^^^^^^^^^^^
# Warning 5 [ignored-partial-application]: this function application is partial,
# maybe some arguments are missing.
# (cd _build/default/test && /home/opam/.opam/5.1.1/bin/js_of_ocaml -o test_jsonoo.bc.js /home/opam/.opam/5.1.1/lib/ojs/ojs_runtime.js test_jsonoo.bc-for-jsoo)
# There are some missing primitives
# Dummy implementations (raising 'Failure' exception) will be used if they are not available at runtime.
# You can prevent the generation of dummy implementations with the commandline option '--disable genprim'
# Missing primitives:
#   caml_zstd_initialize
# File "test/dune", line 6, characters 0-90:
#  6 | (rule
#  7 |  (alias runtest)
#  8 |  (deps test_jsonoo.bc.js)
#  9 |  (action
# 10 |   (run node test_jsonoo.bc.js)))
# (cd _build/default/test && /usr/bin/node test_jsonoo.bc.js)
# Fatal error: exception Failure("caml_zstd_initialize not implemented")

Fixed upstream in ocsigen/js_of_ocaml#1535

…l_zstd_initialize to be implemented in javascript)
@mseri
Copy link
Member

mseri commented Nov 29, 2023

Thanks

@mseri mseri merged commit aa99833 into ocaml:master Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants