Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ Indexer chunk size reduce #360

Merged
merged 26 commits into from
Apr 11, 2024
Merged

Conversation

bogdanfazakas
Copy link
Member

@bogdanfazakas bogdanfazakas commented Mar 19, 2024

Fixes #354 #366 #388 .

Changes proposed in this PR:

  • update reduce chunk size logic
  • split retrieve and process logic for chunk size reduction
  • added lock to loop so we wait util processing certain blocks before starting with new ones(that may start with the same block)
  • refactored the way we used last indexed block inside the indexer thread

@bogdanfazakas bogdanfazakas self-assigned this Mar 19, 2024
@bogdanfazakas bogdanfazakas marked this pull request as ready for review April 1, 2024 11:05
@paulo-ocean
Copy link
Contributor

paulo-ocean commented Apr 8, 2024

hey @bogdanfazakas
can you check the integration test "should store the ddo state in the db with no errors and retrieve it using did"
this seems to be failing since the merge of the "fix ddo state endpoint PR"
thanks

@bogdanfazakas
Copy link
Member Author

hey @bogdanfazakas can you check the integration test "should store the ddo state in the db with no errors and retrieve it using did" this seems to be failing since the merge of the "fix ddo state endpoint PR" thanks

yeah checking it now, strange things going on, was not failing on the branch and also the tests are passing locally 😃
so a bit more to debug

@paulo-ocean
Copy link
Contributor

i was actually reviewing this while you were changing it :-)
anyway, just noticed that your lockProccessing variable is always false, not what you wanted for sure :-)

@bogdanfazakas
Copy link
Member Author

@paulo-ocean & @mariacarmina @jamiehewitt15 this should be ready and should fix also our integration test issues

Copy link
Contributor

@paulo-ocean paulo-ocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@bogdanfazakas bogdanfazakas merged commit 8c4bb05 into develop Apr 11, 2024
6 checks passed
@bogdanfazakas bogdanfazakas deleted the fix/indexer-chunk-size branch April 11, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants