Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ integration test regarding ddo state #389

Closed
wants to merge 5 commits into from

Conversation

bogdanfazakas
Copy link
Member

Fixes #388 .

Changes proposed in this PR:

@bogdanfazakas bogdanfazakas changed the base branch from main to develop April 8, 2024 15:11
@bogdanfazakas
Copy link
Member Author

bogdanfazakas commented Apr 8, 2024

think we can close this @paulo-ocean , was something off with barge as it seems, cause all was green locally and same in the branch i ve merge , also now green on develop after a re-run 🤯

@paulo-ocean
Copy link
Contributor

paulo-ocean commented Apr 8, 2024

think we can close this @paulo-ocean , was something off with barge as it seems, cause all was green locally and same in the branch i ve merge , also now green on develop after a re-run 🤯
ok , lets do it

@paulo-ocean paulo-ocean closed this Apr 8, 2024
@paulo-ocean paulo-ocean reopened this Apr 9, 2024
@paulo-ocean
Copy link
Contributor

this is definitely no ok, there is a bug somewhere, the same test keeps failing randomly , in multiple branches

@bogdanfazakas
Copy link
Member Author

bogdanfazakas commented Apr 9, 2024

this is definitely no ok, there is a bug somewhere, the same test keeps failing randomly , in multiple branches

yes there is an issue with an asset being already active from time to time when just published,
think something related to things that got shared beetween test files
investigating that

@paulo-ocean
Copy link
Contributor

this is definitely no ok, there is a bug somewhere, the same test keeps failing randomly , in multiple branches

yes there is an issue with an asset being already active from time to time when just published, think something related to things that got shared beetween test files investigating that

yeah, i suspect something similar, we are using the sample example DDOs in many places

@bogdanfazakas
Copy link
Member Author

this is definitely no ok, there is a bug somewhere, the same test keeps failing randomly , in multiple branches

yes there is an issue with an asset being already active from time to time when just published, think something related to things that got shared beetween test files investigating that

yeah, i suspect something similar, we are using the sample example DDOs in many places

think i found it, let me test it more, maybe related to indexer loop

@bogdanfazakas
Copy link
Member Author

closing this, fixed in #360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is a failing integration test regarding ddo state
2 participants