Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.3 backport] Fix opam admin check in the presence of the with-dev-setup variable #6332

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

kit-ty-kate
Copy link
Member

@kit-ty-kate kit-ty-kate commented Dec 10, 2024

Backport of #6331 to the 2.3 branch
Queued on #6337

@hannesm
Copy link
Member

hannesm commented Dec 11, 2024

I'm testing this right now, it looks good. Thanks for the prompt fix!

@kit-ty-kate kit-ty-kate changed the title Fix opam admin check in the presence of the with-dev-setup variable [2.3 backport] Fix opam admin check in the presence of the with-dev-setup variable Dec 11, 2024
@kit-ty-kate kit-ty-kate added the PR: QUEUED Pending pull request, waiting for other work to be merged or closed label Dec 11, 2024
@hannesm
Copy link
Member

hannesm commented Dec 11, 2024

this works fine for me, thanks for the quick fix.

@kit-ty-kate kit-ty-kate force-pushed the 2.3-fix-admin-check-installability branch from cf7d11b to 482aba6 Compare December 12, 2024 17:52
@kit-ty-kate kit-ty-kate added STATE: READY TO MERGE and removed PR: QUEUED Pending pull request, waiting for other work to be merged or closed labels Dec 12, 2024
@kit-ty-kate kit-ty-kate force-pushed the 2.3-fix-admin-check-installability branch from 482aba6 to fa95cc5 Compare December 12, 2024 18:03
@kit-ty-kate kit-ty-kate merged commit 35acd0c into ocaml:2.3 Dec 12, 2024
39 checks passed
@kit-ty-kate kit-ty-kate deleted the 2.3-fix-admin-check-installability branch December 12, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants