Fix opam admin check in the presence of the with-dev-setup variable #6331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
force-pushed
the
fix-admin-check-installability
branch
from
4f1308f to
f3bc5fe
Compare
This was referenced Dec 10, 2024
kit-ty-kate
force-pushed
the
fix-admin-check-installability
branch
from
f3bc5fe to
849d19b
Compare
kit-ty-kate
force-pushed
the
fix-admin-check-installability
branch
2 times, most recently
from
0093024 to
245b06f
Compare
kit-ty-kate
force-pushed
the
fix-admin-check-installability
branch
from
245b06f to
4a441e5
Compare
Co-authored-by: Raja Boujbel <[email protected]>
kit-ty-kate
force-pushed
the
fix-admin-check-installability
branch
from
2e5fe88 to
1eb7858
Compare
rjbou
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported to 2.3 in #6332
Fixes #6329
Currently any use of
opam admin checkresults in the crash reported in #6329 as soon as a package containingwith-dev-setupis encountered. This is the case since opam 2.2 (#4175) so i think it warrants a backport in opam 2.3. I don't think a backport to 2.2 is necessary given the very low number of use and hyper-specialty of this subcommand.