-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store commitments in blob #2967
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2967 +/- ##
=======================================
Coverage 76.81% 76.82%
=======================================
Files 260 260
Lines 61371 61307 -64
=======================================
- Hits 47145 47098 -47
+ Misses 14226 14209 -17 ☔ View full report in Codecov by Sentry. |
6e28e8e
to
8128e3d
Compare
@@ -26,18 +25,6 @@ pub fn commit_to_field_elems<G: CommitmentCurve>( | |||
.collect() | |||
} | |||
|
|||
#[instrument(skip_all)] | |||
pub fn commit_to_blob<G: CommitmentCurve>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not deleted -- this and the tests below just got moved to the blob
module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Summary
This PR changes the way we (de)serialize blobs to use macros rather than doing it manually -- there should be no net effect. I also started storing the commitments in the blob metadata to save us from having to recompute them for reads.
Finally there is a small change to the "sanity check" to make sure the user and storage provider agree on the data. This is not strictly part of the protocol, but rather it helps with the testing.
Changes
FieldBlob
struct: otherwise we will need to recompute them for each read request. This meansFieldBlob
is now parameterized by the group instead of the scalar field.