Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verify-storage-proof command to cli and e2e #2979

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

martyall
Copy link
Contributor

@martyall martyall commented Jan 30, 2025

Summary

Second part of #2985 -- added the verify-storage-proof command to the cli and to the e2e script, completing the e2e user flow for

  • upload data to SP
  • request proof of storage from SP
  • verify proof of storage

Changes

  • Added verify-storage-proof command to cli and e2e script.
  • store the alpha and folded_commitment values on the blob struct. 9ff0ae7
  • use the folded_commitment as the sanity-check between the user/verifyer and storage provider. There has been some back and forth on this (see here and here), but it greatly simplifies things to do this and its cheap. see this diff for details

@martyall martyall changed the title Add storage-proof verify-storage-proof to cli and e2e Add storage-proof / verify-storage-proof to cli and e2e Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 13.33333% with 52 lines in your changes missing coverage. Please review.

Project coverage is 77.05%. Comparing base (bd4a885) to head (40d56e7).
Report is 26 commits behind head on master.

Files with missing lines Patch % Lines
saffron/src/main.rs 0.00% 34 Missing ⚠️
saffron/src/commitment.rs 0.00% 14 Missing ⚠️
saffron/src/cli.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2979      +/-   ##
==========================================
+ Coverage   76.93%   77.05%   +0.12%     
==========================================
  Files         262      260       -2     
  Lines       61614    61445     -169     
==========================================
- Hits        47401    47345      -56     
+ Misses      14213    14100     -113     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martyall martyall mentioned this pull request Jan 30, 2025
Base automatically changed from martin/saffron-proof-of-storage-clean to master January 30, 2025 22:12
@martyall martyall changed the base branch from master to martin/saffron-proof-of-storage-clean-e2e-part-1 January 30, 2025 22:16
@martyall martyall changed the title Add storage-proof / verify-storage-proof to cli and e2e Add verify-storage-proof to cli and e2e Jan 30, 2025
@martyall martyall changed the title Add verify-storage-proof to cli and e2e Add verify-storage-proof command to cli and e2e Jan 30, 2025
@martyall martyall marked this pull request as ready for review January 30, 2025 22:44
Base automatically changed from martin/saffron-proof-of-storage-clean-e2e-part-1 to master February 3, 2025 15:50
@martyall martyall merged commit 56a3f17 into master Feb 3, 2025
13 checks passed
@martyall martyall deleted the martin/saffron-proof-of-storage-clean-e2e branch February 3, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants