Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make nightly build pipeline faster #1949

Closed
wants to merge 21 commits into from

Conversation

BulkBeing
Copy link
Contributor

@BulkBeing BulkBeing commented Aug 16, 2024

Closes #1943

Improve the build time of the nightly build pipeline.

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.75%. Comparing base (0489eae) to head (58ecdd3).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1949      +/-   ##
==========================================
- Coverage   57.82%   53.75%   -4.07%     
==========================================
  Files         412      284     -128     
  Lines       28789    22140    -6649     
==========================================
- Hits        16646    11902    -4744     
+ Misses      11203     9297    -1906     
- Partials      940      941       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
@vigith vigith linked an issue Aug 16, 2024 that may be closed by this pull request
@KeranYang
Copy link
Member

KeranYang commented Aug 16, 2024

@BulkBeing thanks for making the change. It seems failing the monovertex e2e test. Since the test executes the mono vertex which is written in Rust, I suspect it might related to the image build change in the PR. Please check. You can run make TestMonoVertexWithTransformer locally to execute the test. Thanks!

@BulkBeing
Copy link
Contributor Author

A new PR (#1958 ) was created with the same changes since I was not able to figure out why the CI pipelines were failing here. Tried smaller changes at a time in the new PR. The tests were failing because the numaflow-rs binary didn't had executable permission within the image. Will do further follow ups in the new PR

@BulkBeing BulkBeing closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve build time for Rust compilation
2 participants