Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cache daemon client for each pipeline #1276

Merged
merged 25 commits into from
Nov 2, 2023
Merged

feat: cache daemon client for each pipeline #1276

merged 25 commits into from
Nov 2, 2023

Conversation

dpadhiar
Copy link
Contributor

Explain what this PR does.

Cache client for each pipeline to reduce creation of them for each call to pipeline APIs.

@dpadhiar
feat: cache client
ee386bc 
Signed-off-by: Dillen Padhiar <[email protected]>
@whynowy
Copy link
Member

whynowy commented Oct 26, 2023

Refer to https://github.com/numaproj/numaflow/blob/main/pkg/reconciler/vertex/scaling/scaling.go#L51

whynowy
whynowy reviewed Oct 27, 2023
View reviewed changes
server/apis/v1/handler.go Outdated Show resolved Hide resolved
@dpadhiar dpadhiar mentioned this pull request Oct 27, 2023
Closed
2 tasks
@dpadhiar dpadhiar marked this pull request as ready for review October 30, 2023 20:42
@dpadhiar dpadhiar requested a review from vigith as a code owner October 30, 2023 20:42
@dpadhiar dpadhiar requested review from whynowy and jy4096 November 2, 2023 00:52
@whynowy whynowy merged commit 42f81df into numaproj:main Nov 2, 2023
17 checks passed
whynowy pushed a commit that referenced this pull request Nov 2, 2023
@dpadhiar @whynowy
feat: cache daemon client for each pipeline (#1276)
4ffda38 
Signed-off-by: Dillen Padhiar <[email protected]>
(cherry picked from commit 42f81df)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whynowy whynowy whynowy approved these changes

@vigith vigith Awaiting requested review from vigith vigith is a code owner

@jy4096 jy4096 Awaiting requested review from jy4096

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpadhiar @whynowy @jy4096