Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numaflow server v1_1 APIs #1031

Closed
2 tasks
whynowy opened this issue Sep 11, 2023 · 2 comments
Closed
2 tasks

Numaflow server v1_1 APIs #1031

whynowy opened this issue Sep 11, 2023 · 2 comments
Assignees
Labels
area/ui User Interface enhancement New feature or request
Milestone

Comments

@whynowy
Copy link
Member

whynowy commented Sep 11, 2023

Summary

As we are building new Numaflow UX, we need a new set of RESTful APIs (v1_1) for new UX components.

  • Scaffold the code structure for v1_1 routing.
  • xxx

Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@whynowy whynowy added enhancement New feature or request area/ui User Interface labels Sep 11, 2023
@whynowy whynowy modified the milestones: 1.0, v0.11 Sep 11, 2023
@jy4096
Copy link
Contributor

jy4096 commented Oct 4, 2023

#1161

@jy4096
Copy link
Contributor

jy4096 commented Oct 4, 2023

TODOs

  1. server/apis/v1/handler.go
    (159, 8) // TODO(API) : Get the current status of the ISB service
    (274, 5) // TODO: the client should be cached. feat: cache daemon client for each pipeline #1276
    (395, 5) // TODO: validate the patched data as well, e.g. only allow lifecycle to be patched
    (458, 5) // TODO(API) : Get the current status of the ISB service
    (508, 5) // TODO: validate if it's being used by any pipelines (WIP: jy4096)
    (523, 5) // TODO: the client should be cached.
    (544, 5) // TODO: the client should be cached.
    (624, 5) // TODO: the client should be cached.
    (825, 6) // TODO(API) : Get the current status of the ISB service
    (833, 4) // TODO(API): Change the Daemon service to return the consolidated status of the pipeline (SKIP)
    issue feat: improve API cluster-summary performance #1161 (WIP: jy4096)

  2. server/apis/v1/routes/routes.go
    (30, 5) // TODO: Get the version of the current Numaflow

  3. e2e missing tests (at least 1 test)
    r.PUT("/namespaces/:namespace/pipelines/:pipeline", handler.UpdatePipeline)
    r.PATCH("/namespaces/:namespace/pipelines/:pipeline", handler.PatchPipeline)
    r.PUT("/namespaces/:namespace/isb-services/:isb-services", handler.UpdateInterStepBufferService)
    r.PUT("/namespaces/:namespace/pipelines/:pipeline/vertices/:vertex", handler.UpdateVertex)
    r.GET("/metrics/namespaces/:namespace/pods/", handler.ListPodsMetrics) // tested in postman but got 301 error code in e2e test
    r.GET("/namespaces/:namespace/pods/:pod/logs", handler.PodLogs) // tested in postman but failed to add in e2e test
    r.GET("/namespaces/:namespace/events", handler.GetNamespaceEvents)
    r.POST("/validation/pipeline", handler.ValidatePipeline)
    r.POST("/validation/isb-service", handler.ValidateInterStepBufferService)

  4. e2e api-test improvement

@vigith vigith modified the milestones: v0.11, 1.0 Oct 31, 2023
@whynowy whynowy closed this as completed Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui User Interface enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants