Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix sideinput-udf image build #103

Merged
merged 1 commit into from
Nov 13, 2024
Merged

chore: fix sideinput-udf image build #103

merged 1 commit into from
Nov 13, 2024

Conversation

BulkBeing
Copy link
Collaborator

The image build started failing after the changes for using cargo workspaces:

  ./hack/update_examples.sh --build-push-example examples/sideinput/udf
  shell: /usr/bin/bash -e {0}
Using tag: stable
cargo check
error: current package believes it's in a workspace when it's not:
current:   /home/runner/work/numaflow-rs/numaflow-rs/examples/sideinput/udf/Cargo.toml
workspace: /home/runner/work/numaflow-rs/numaflow-rs/Cargo.toml

this may be fixable by adding `examples/sideinput/udf` to the `workspace.members` array of the manifest located at: /home/runner/work/numaflow-rs/numaflow-rs/Cargo.toml
Alternatively, to keep it out of the workspace, add the package to the `workspace.exclude` array, or add an empty `[workspace]` table to the package's manifest.
make: *** [Makefile:8: update] Error 101
Error: failed to run make image in examples/sideinput/udf
Error: Process completed with exit code 1.

@BulkBeing BulkBeing requested review from kohlisid and vigith November 12, 2024 14:27
@KeranYang KeranYang changed the title chore: Fix sideinput-udf image build chore: fix sideinput-udf image build Nov 12, 2024
@vigith vigith merged commit 93f2864 into main Nov 13, 2024
2 checks passed
@vigith vigith deleted the fix-image-build branch November 13, 2024 15:01
BulkBeing added a commit that referenced this pull request Nov 15, 2024
BulkBeing added a commit that referenced this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants