Skip to content

Commit

Permalink
chore: fix sideinput-udf image build (#103)
Browse files Browse the repository at this point in the history
Signed-off-by: Sreekanth <[email protected]>
  • Loading branch information
BulkBeing committed Nov 15, 2024
1 parent 11598f9 commit cd01142
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 15 deletions.
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[workspace]
members = ["numaflow", "examples/*"]
members = ["numaflow", "examples/*", "examples/sideinput/udf"]
# Only check / build main crate by default (check all with `--workspace`)
default-members = ["numaflow"]
resolver = "2"
Expand Down
2 changes: 1 addition & 1 deletion examples/sideinput/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ WORKDIR /numaflow-rs/examples/sideinput
RUN cargo build --release

# our final base
FROM rust AS sideinput
FROM debian:bullseye AS sideinput

# copy the build artifact from the build stage
COPY --from=build /numaflow-rs/target/release/sideinput .
Expand Down
8 changes: 2 additions & 6 deletions examples/sideinput/udf/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,9 @@ edition = "2021"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[[bin]]
name = "server"
path = "src/main.rs"

[dependencies]
tonic = "0.10.2"
tokio = { version = "1.0", features = ["macros", "rt-multi-thread"] }
numaflow = { path = "../../../" }
numaflow = { path = "../../../numaflow" }
chrono = "0.4.30"
notify = "6.1.1"
notify = "6.1.1"
6 changes: 3 additions & 3 deletions examples/sideinput/udf/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM rust:1.80-bookworm AS build
FROM rust:1.82-bullseye AS build

RUN apt-get update
RUN apt-get install protobuf-compiler -y
Expand All @@ -14,9 +14,9 @@ RUN cargo build --release
FROM debian:bookworm AS sideinput-udf

# copy the build artifact from the build stage
COPY --from=build /numaflow-rs/examples/sideinput/udf/target/release/server .
COPY --from=build /numaflow-rs/target/release/sideinput-udf .

RUN mkdir -p /var/numaflow/sideinputs

# set the startup command to run your binary
CMD ["./server"]
CMD ["./sideinput-udf"]
4 changes: 0 additions & 4 deletions examples/sideinput/udf/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,3 @@ image: update
-f ${DOCKER_FILE_PATH} \
-t ${IMAGE_REGISTRY} .
@if [ "$(PUSH)" = "true" ]; then docker push ${IMAGE_REGISTRY}; fi

.PHONY: clean
clean:
-rm -rf target

0 comments on commit cd01142

Please sign in to comment.