Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unloadOthers option into CreateSceneAttribute #113

Merged
merged 5 commits into from
Jan 5, 2025

Conversation

nowsprinting
Copy link
Owner

Changes

  • Add unloadOthers option into CreateSceneAttribute
  • Refactor

@Copilot Copilot bot review requested due to automatic review settings January 5, 2025 13:35
@github-actions github-actions bot added the enhancement New feature or request label Jan 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • Tests/Editor/Attributes.meta: Language not supported
Comments suppressed due to low confidence (1)

Tests/Editor/Attributes/CreateSceneAttributeTest.cs:9

  • [nitpick] The namespace change should be consistent across the codebase. Ensure that all references to TestHelper.Editor are updated to TestHelper.Editor.Attributes if this change is intended.
namespace TestHelper.Editor.Attributes

This comment has been minimized.

Copy link

github-actions bot commented Jan 5, 2025

Code Metrics Report

master (3495ef9) #113 (975ade0) +/-
Coverage 78.1% 78.7% +0.5%
Code to Test Ratio 1:0.7 1:0.7 +0.0
Test Execution Time 4m13s 3m28s -45s
Details
  |                     | master (3495ef9) | #113 (975ade0) |  +/-  |
  |---------------------|------------------|----------------|-------|
+ | Coverage            |            78.1% |          78.7% | +0.5% |
  |   Files             |               35 |             35 |     0 |
  |   Lines             |             1036 |           1064 |   +28 |
+ |   Covered           |              810 |            838 |   +28 |
+ | Code to Test Ratio  |            1:0.7 |          1:0.7 |  +0.0 |
  |   Code              |             1828 |           1860 |   +32 |
+ |   Test              |             1421 |           1448 |   +27 |
+ | Test Execution Time |            4m13s |          3m28s |  -45s |

Code coverage of files in pull request scope (100.0% → 100.0%)

Files Coverage +/-
Runtime/Attributes/CreateSceneAttribute.cs 100.0% 0.0%

Reported by octocov

@nowsprinting nowsprinting merged commit 4f00648 into master Jan 5, 2025
14 checks passed
@nowsprinting nowsprinting deleted the feature/unload_other_scenes_option branch January 5, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant