Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scene unload error on AfterTest in CreatedSceneAttribute #116

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

nowsprinting
Copy link
Owner

Problem

Can not unload attribute-created-scene on AfterTest method in CreatedSceneAttribute.

AfterTest : System.ArgumentException : Scene to unload is invalid

Condition

Unload attribute-created-scene in test.
e.g., LoadScene

Fixes

Skip unload if attribute-created-scene was unloaded.

refs #113

@Copilot Copilot bot review requested due to automatic review settings January 6, 2025 22:49
@github-actions github-actions bot added the bug Something isn't working label Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Copy link

github-actions bot commented Jan 6, 2025

Code Metrics Report

master (a4a5608) #116 (5b3790a) +/-
Coverage 78.7% 78.8% +0.0%
Code to Test Ratio 1:0.7 1:0.7 +0.0
Test Execution Time 3m56s 3m40s -16s
Details
  |                     | master (a4a5608) | #116 (5b3790a) |  +/-  |
  |---------------------|------------------|----------------|-------|
+ | Coverage            |            78.7% |          78.8% | +0.0% |
  |   Files             |               35 |             35 |     0 |
  |   Lines             |             1064 |           1067 |    +3 |
+ |   Covered           |              838 |            841 |    +3 |
+ | Code to Test Ratio  |            1:0.7 |          1:0.7 |  +0.0 |
  |   Code              |             1859 |           1863 |    +4 |
+ |   Test              |             1448 |           1457 |    +9 |
+ | Test Execution Time |            3m56s |          3m40s |  -16s |

Code coverage of files in pull request scope (100.0% → 100.0%)

Files Coverage +/-
Runtime/Attributes/CreateSceneAttribute.cs 100.0% 0.0%

Reported by octocov

@nowsprinting nowsprinting merged commit dcdc3eb into master Jan 6, 2025
15 checks passed
@nowsprinting nowsprinting deleted the fix/createscene_aftertest branch January 6, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant