NC | CLI | Fix for unsettable flags issues #8774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romayalon
force-pushed
the
romy-cli-fix-unset-issue
branch
from
ad60d08 to
aab5631
Compare
romayalon
force-pushed
the
romy-cli-fix-unset-issue
branch
from
8478075 to
ffeee03
Compare
achouhan09
reviewed
Feb 7, 2025
romayalon
force-pushed
the
romy-cli-fix-unset-issue
branch
from
d38e302 to
f934496
Compare
shirady
reviewed
Feb 10, 2025
2 tasks
romayalon
force-pushed
the
romy-cli-fix-unset-issue
branch
2 times, most recently
from
e74f1e9 to
05a8ed9
Compare
shirady
approved these changes
Feb 10, 2025
romayalon
force-pushed
the
romy-cli-fix-unset-issue
branch
from
3e19320 to
7dbd3dd
Compare
Signed-off-by: Romy <[email protected]>
romayalon
force-pushed
the
romy-cli-fix-unset-issue
branch
from
7dbd3dd to
9f981fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
This PR fixes 3 issues with CLI unsettable flags and a tiny test rename refactoring -
LIST_UNSETABLE_OPTIONSwas missing some flags that were supposed to be included in it and be checked, their check passed because their type was string (See bullet 1).The missing options were new_buckets_path (was missing also in the help) and supplemental_groups.
LIST_UNSETABLE_OPTIONSconsisted s3_policy flag which does not exist, changed it to bucket_policy.test_nc_nsfs_account_cli.test.js -> test_nc_account_cli.test.jsand it's references.** Found this bug during the reviewing of - #8722, hopefully it can help @achouhan09 with the comment #8722 (comment)
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: