Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC | Test Files | Remove nsfs From File Name and Update Docs #8780

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Feb 10, 2025

Explain the changes

  1. Remove nsfs from test file names:
  • test_nc_bucket_cli.test.js
  • test_nc_account_cli.test.js (and also rename tmp_fs_path according to the file's name)
  • test_nc_anonymous_cli.test.js
  • test_nc_connection_cli.test.js (and also rename tmp_fs_path according to the file's name and add this file in the docs)
    Note: for jest test names, we just update the file name without any additional rename.
  1. Update the documentation file CI&Tests.md accordingly.

Issues:

  1. It is a partial fix of NC | Unit tests suggestions and refactoring #8056: "12. Rename the file test_nc_nsfs_bucket_cli.test.js to test_nc_bucket_cli.test.js (notice that we also have the file test_nc_nsfs_account_cli.test.js and we also need to update the CI&Tests.md)" that was raised in PR NC | NSFS | CLI | Separate Bucket and Account List Functions #8747 as a GAP.
  2. Comes after PR NC | CLI | Fix for unsettable flags issues #8774 (some of the content is already there).

Testing Instructions:

  1. none, will be tested in the CI.
  • Doc added/updated
  • Tests added

@shirady shirady force-pushed the nc-remove-nsfs-name branch from 44365f5 to 7b35628 Compare February 12, 2025 07:12
@shirady shirady requested a review from romayalon February 12, 2025 07:44
@shirady shirady force-pushed the nc-remove-nsfs-name branch from 7b35628 to 4fbb310 Compare February 12, 2025 13:19
@shirady shirady force-pushed the nc-remove-nsfs-name branch from 4fbb310 to f3ec6eb Compare February 13, 2025 06:40
@shirady shirady merged commit 7bfd5a3 into noobaa:master Feb 13, 2025
11 checks passed
@shirady shirady deleted the nc-remove-nsfs-name branch February 13, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants