Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add eslint dev dependency to noir_wasm #4342

Merged
merged 5 commits into from
Feb 12, 2024
Merged

chore: add eslint dev dependency to noir_wasm #4342

merged 5 commits into from
Feb 12, 2024

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Summary*

While looking at #4338 I noticed that we weren't linting noir_wasm. This PR adds eslint dependencies

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray kevaundray added this pull request to the merge queue Feb 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2024
@TomAFrench TomAFrench added this pull request to the merge queue Feb 12, 2024
Merged via the queue into master with commit 3d65018 Feb 12, 2024
39 checks passed
@TomAFrench TomAFrench deleted the tf/lint-noir-wasm branch February 12, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomAFrench @kevaundray