Skip to content

Commit

Permalink
chore: add eslint dev dependency to noir_wasm (#4342)
Browse files Browse the repository at this point in the history
# Description

## Problem\*



## Summary\*

While looking at #4338 I noticed that we weren't linting noir_wasm. This
PR adds `eslint` dependencies

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
  • Loading branch information
TomAFrench authored Feb 12, 2024
1 parent 8f024a8 commit 3d65018
Show file tree
Hide file tree
Showing 12 changed files with 34 additions and 26 deletions.
2 changes: 1 addition & 1 deletion acvm-repo/acvm_js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"@web/test-runner": "^0.15.3",
"@web/test-runner-playwright": "^0.10.0",
"chai": "^4.3.7",
"eslint": "^8.50.0",
"eslint": "^8.56.0",
"eslint-plugin-prettier": "^5.0.0",
"mocha": "^10.2.0",
"prettier": "3.0.3",
Expand Down
2 changes: 1 addition & 1 deletion compiler/integration-tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"@web/dev-server-esbuild": "^0.3.6",
"@web/test-runner": "^0.15.3",
"@web/test-runner-playwright": "^0.10.0",
"eslint": "^8.50.0",
"eslint": "^8.56.0",
"eslint-plugin-prettier": "^5.0.0",
"ethers": "^6.7.1",
"hardhat": "^2.17.4",
Expand Down
1 change: 1 addition & 0 deletions compiler/wasm/.eslintignore
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
node_modules
dist
3 changes: 3 additions & 0 deletions compiler/wasm/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,14 @@
"browserify-fs": "^1.0.0",
"chai": "^4.3.10",
"copy-webpack-plugin": "^11.0.0",
"eslint": "^8.56.0",
"eslint-plugin-prettier": "^5.0.0",
"html-webpack-plugin": "^5.5.4",
"memfs": "^4.6.0",
"mocha": "^10.2.0",
"mocha-each": "^2.0.1",
"path-browserify": "^1.0.1",
"prettier": "3.0.3",
"process": "^0.11.10",
"readable-stream": "^4.4.2",
"sinon": "^17.0.1",
Expand Down
3 changes: 2 additions & 1 deletion compiler/wasm/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,6 @@
"module": "CommonJS",
"moduleResolution": "Node",
"allowJs": true,
}
},
"exclude": ["node_modules"]
}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"@typescript-eslint/parser": "^6.7.3",
"chai": "^4.3.7",
"cspell": "^8.3.2",
"eslint": "^8.50.0",
"eslint": "^8.56.0",
"eslint-plugin-prettier": "^5.0.0",
"mocha": "^10.2.0",
"prettier": "3.0.3",
Expand Down
2 changes: 1 addition & 1 deletion tooling/noir_codegen/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"@types/node": "^20.6.2",
"@types/prettier": "^3",
"chai": "^4.3.8",
"eslint": "^8.50.0",
"eslint": "^8.56.0",
"eslint-plugin-prettier": "^5.0.0",
"mocha": "^10.2.0",
"prettier": "3.0.3",
Expand Down
2 changes: 1 addition & 1 deletion tooling/noir_js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"@types/node": "^20.6.2",
"@types/prettier": "^3",
"chai": "^4.3.8",
"eslint": "^8.50.0",
"eslint": "^8.56.0",
"eslint-plugin-prettier": "^5.0.0",
"mocha": "^10.2.0",
"prettier": "3.0.3",
Expand Down
2 changes: 1 addition & 1 deletion tooling/noir_js_backend_barretenberg/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"@types/node": "^20.6.2",
"@types/prettier": "^3",
"chai": "^4.3.8",
"eslint": "^8.50.0",
"eslint": "^8.56.0",
"eslint-plugin-prettier": "^5.0.0",
"mocha": "^10.2.0",
"prettier": "3.0.3",
Expand Down
2 changes: 1 addition & 1 deletion tooling/noir_js_types/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
},
"devDependencies": {
"@types/prettier": "^3",
"eslint": "^8.50.0",
"eslint": "^8.56.0",
"eslint-plugin-prettier": "^5.0.0",
"prettier": "3.0.3",
"typescript": "^5.2.2"
Expand Down
2 changes: 1 addition & 1 deletion tooling/noirc_abi_wasm/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"@web/dev-server-esbuild": "^0.3.6",
"@web/test-runner": "^0.15.3",
"@web/test-runner-playwright": "^0.10.0",
"eslint": "^8.50.0",
"eslint": "^8.56.0",
"mocha": "^10.2.0"
}
}
37 changes: 20 additions & 17 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3485,10 +3485,10 @@ __metadata:
languageName: node
linkType: hard

"@eslint/js@npm:8.55.0":
version: 8.55.0
resolution: "@eslint/js@npm:8.55.0"
checksum: fa33ef619f0646ed15649b0c2e313e4d9ccee8425884bdbfc78020d6b6b64c0c42fa9d83061d0e6158e1d4274f03f0f9008786540e2efab8fcdc48082259908c
"@eslint/js@npm:8.56.0":
version: 8.56.0
resolution: "@eslint/js@npm:8.56.0"
checksum: 5804130574ef810207bdf321c265437814e7a26f4e6fac9b496de3206afd52f533e09ec002a3be06cd9adcc9da63e727f1883938e663c4e4751c007d5b58e539
languageName: node
linkType: hard

Expand Down Expand Up @@ -4366,7 +4366,7 @@ __metadata:
"@web/test-runner": ^0.15.3
"@web/test-runner-playwright": ^0.10.0
chai: ^4.3.7
eslint: ^8.50.0
eslint: ^8.56.0
eslint-plugin-prettier: ^5.0.0
mocha: ^10.2.0
prettier: 3.0.3
Expand All @@ -4384,7 +4384,7 @@ __metadata:
"@types/node": ^20.6.2
"@types/prettier": ^3
chai: ^4.3.8
eslint: ^8.50.0
eslint: ^8.56.0
eslint-plugin-prettier: ^5.0.0
fflate: ^0.8.0
mocha: ^10.2.0
Expand All @@ -4405,7 +4405,7 @@ __metadata:
"@types/node": ^20.6.2
"@types/prettier": ^3
chai: ^4.3.8
eslint: ^8.50.0
eslint: ^8.56.0
eslint-plugin-prettier: ^5.0.0
glob: ^10.3.10
mocha: ^10.2.0
Expand All @@ -4431,7 +4431,7 @@ __metadata:
"@types/node": ^20.6.2
"@types/prettier": ^3
chai: ^4.3.8
eslint: ^8.50.0
eslint: ^8.56.0
eslint-plugin-prettier: ^5.0.0
mocha: ^10.2.0
prettier: 3.0.3
Expand Down Expand Up @@ -4468,12 +4468,15 @@ __metadata:
browserify-fs: ^1.0.0
chai: ^4.3.10
copy-webpack-plugin: ^11.0.0
eslint: ^8.56.0
eslint-plugin-prettier: ^5.0.0
html-webpack-plugin: ^5.5.4
memfs: ^4.6.0
mocha: ^10.2.0
mocha-each: ^2.0.1
pako: ^2.1.0
path-browserify: ^1.0.1
prettier: 3.0.3
process: ^0.11.10
readable-stream: ^4.4.2
sinon: ^17.0.1
Expand All @@ -4496,7 +4499,7 @@ __metadata:
"@web/dev-server-esbuild": ^0.3.6
"@web/test-runner": ^0.15.3
"@web/test-runner-playwright": ^0.10.0
eslint: ^8.50.0
eslint: ^8.56.0
mocha: ^10.2.0
languageName: unknown
linkType: soft
Expand All @@ -4509,7 +4512,7 @@ __metadata:
"@typescript-eslint/parser": ^6.7.3
chai: ^4.3.7
cspell: ^8.3.2
eslint: ^8.50.0
eslint: ^8.56.0
eslint-plugin-prettier: ^5.0.0
mocha: ^10.2.0
prettier: 3.0.3
Expand All @@ -4523,7 +4526,7 @@ __metadata:
resolution: "@noir-lang/types@workspace:tooling/noir_js_types"
dependencies:
"@types/prettier": ^3
eslint: ^8.50.0
eslint: ^8.56.0
eslint-plugin-prettier: ^5.0.0
prettier: 3.0.3
typescript: ^5.2.2
Expand Down Expand Up @@ -10852,14 +10855,14 @@ __metadata:
languageName: node
linkType: hard

"eslint@npm:^8.50.0":
version: 8.55.0
resolution: "eslint@npm:8.55.0"
"eslint@npm:^8.56.0":
version: 8.56.0
resolution: "eslint@npm:8.56.0"
dependencies:
"@eslint-community/eslint-utils": ^4.2.0
"@eslint-community/regexpp": ^4.6.1
"@eslint/eslintrc": ^2.1.4
"@eslint/js": 8.55.0
"@eslint/js": 8.56.0
"@humanwhocodes/config-array": ^0.11.13
"@humanwhocodes/module-importer": ^1.0.1
"@nodelib/fs.walk": ^1.2.8
Expand Down Expand Up @@ -10896,7 +10899,7 @@ __metadata:
text-table: ^0.2.0
bin:
eslint: bin/eslint.js
checksum: 83f82a604559dc1faae79d28fdf3dfc9e592ca221052e2ea516e1b379b37e77e4597705a16880e2f5ece4f79087c1dd13fd7f6e9746f794a401175519db18b41
checksum: 883436d1e809b4a25d9eb03d42f584b84c408dbac28b0019f6ea07b5177940bf3cca86208f749a6a1e0039b63e085ee47aca1236c30721e91f0deef5cc5a5136
languageName: node
linkType: hard

Expand Down Expand Up @@ -13285,7 +13288,7 @@ __metadata:
"@web/dev-server-esbuild": ^0.3.6
"@web/test-runner": ^0.15.3
"@web/test-runner-playwright": ^0.10.0
eslint: ^8.50.0
eslint: ^8.56.0
eslint-plugin-prettier: ^5.0.0
ethers: ^6.7.1
hardhat: ^2.17.4
Expand Down

0 comments on commit 3d65018

Please sign in to comment.