Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMAKE_INSTALL_LIBDIR exampel in README.md #200

Closed
wants to merge 1 commit into from
Closed

Fix CMAKE_INSTALL_LIBDIR exampel in README.md #200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ $ sudo systemctl start mosquitto
### Build and Run test
```
# cd $NNST_EDGE_ROOT
$ cmake -B build -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_INSTALL_LIBDIR=lib -DENABLE_TEST=ON -DMQTT_SUPPORT=ON
$ cmake -B build -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_INSTALL_LIBDIR=/lib -DENABLE_TEST=ON -DMQTT_SUPPORT=ON
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. We don't install our .so files at /lib. I think the CMakeLists.txt is not handling install direcctories properly for creating .pc files. It should depend on PREFIX. (i.e., $PREFIX/$LIBDIR)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@myungjoo Thanks for your comment.
I agree your comment. It seems that the LIBDIR path is not used properly in the CMakeLists.txt file.
I will close this PR and fix the problem, and create a new PR.

thank you!! 👍

$ make -C build install

# Run test
Expand Down
Loading