Fix CMAKE_INSTALL_LIBDIR exampel in README.md #200
Conversation
linuxias
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
anyj0527 and
gichan-jang
as code owners
|
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #200. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/. |
|
INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://ci.nnstreamer.ai/nnstreamer-edge/ci/repo-workers/pr-checker/200-202402272300190.54708003997803-548693b7d7dcc1ba1a16cced86f98a23de54c861/report/misspelling_result.txt. |
In README, CMAKE_INSTALL_LIBDIR is set up with the "lib" path. The lib path is recorded in the pc file referenced by the pkg-config tool. This path must be modified to the absolute path "/lib". Signed-off-by: linuxias <[email protected]>
|
INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://ci.nnstreamer.ai/nnstreamer-edge/ci/repo-workers/pr-checker/200-202402272300480.81850290298462-8df0279175a61d204354d08be04c557e6915629a/report/misspelling_result.txt. |
| @@ -45,7 +45,7 @@ $ sudo systemctl start mosquitto | |||
| ### Build and Run test | |||
| ``` | |||
| # cd $NNST_EDGE_ROOT | |||
| $ cmake -B build -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_INSTALL_LIBDIR=lib -DENABLE_TEST=ON -DMQTT_SUPPORT=ON | |||
| $ cmake -B build -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_INSTALL_LIBDIR=/lib -DENABLE_TEST=ON -DMQTT_SUPPORT=ON | |||
There was a problem hiding this comment.
Nope. We don't install our .so files at /lib. I think the CMakeLists.txt is not handling install direcctories properly for creating .pc files. It should depend on PREFIX. (i.e., $PREFIX/$LIBDIR)
There was a problem hiding this comment.
@myungjoo Thanks for your comment.
I agree your comment. It seems that the LIBDIR path is not used properly in the CMakeLists.txt file.
I will close this PR and fix the problem, and create a new PR.
thank you!! 👍
In README, CMAKE_INSTALL_LIBDIR is set up with the "lib" path.
The lib path is recorded in the pc file referenced by the pkg-config tool.
This path must be modified to the absolute path "/lib".