Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force rust toolchain for web-client NPM build #3040

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Force rust toolchain for web-client NPM build #3040

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/npm_publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,15 @@ jobs:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
Copy link
Member

@Eligioo Eligioo Nov 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you want to use a different toolchain other than the current stable, you are supposed to get it by: dtolnay/[email protected].

The selection of Rust toolchain is made based on the particular @ rev of this Action being requested. For example "dtolnay/rust-toolchain@nightly" pulls in the nightly Rust toolchain, while "dtolnay/[email protected]" pulls in 1.42.0.

Important: the default is to match the @ rev as described above. When passing an explicit toolchain as an input instead of @ rev, you'll want to use "dtolnay/rust-toolchain@master" as the revision of the action.

Copy link
Member Author

@sisou sisou Nov 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welp, it still works. If they want to enforce that, they should prevent the other ways from working :D

with:
toolchain: 1.81.0
targets: wasm32-unknown-unknown
- uses: Swatinem/rust-cache@v2
- uses: jetli/[email protected]
with:
version: 'latest'
- name: Build package
working-directory: ./web-client
run: ./scripts/build.sh
- uses: actions/setup-node@v4
with:
node-version: '18.x'
registry-url: 'https://registry.npmjs.org'
- run: npm install -g npm
- name: Publish to npm
working-directory: ./web-client/dist
run: npm publish --tag next --provenance
Expand Down