Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force rust toolchain for web-client NPM build #3040

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

sisou
Copy link
Member

@sisou sisou commented Nov 12, 2024

This fixes #3022.

Pull request checklist

  • All tests pass. The project builds and runs.
  • I have resolved any merge conflicts.
  • I have resolved all clippy and rustfmt warnings.

@sisou sisou added the WASM label Nov 12, 2024
@sisou sisou self-assigned this Nov 12, 2024
@sisou sisou force-pushed the soeren/npm-ci branch 2 times, most recently from 8c35560 to 1eba829 Compare November 12, 2024 16:24
@sisou
Copy link
Member Author

sisou commented Nov 12, 2024

Manual CI run with this branch passed: https://github.com/nimiq/core-rs-albatross/actions/runs/11801453470

And remove unnecessary steps and deviations from the default.

[skip ci]
@jsdanielh jsdanielh merged commit 233b125 into albatross Nov 12, 2024
@jsdanielh jsdanielh deleted the soeren/npm-ci branch November 12, 2024 18:19
@@ -14,19 +14,15 @@ jobs:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
Copy link
Member

@Eligioo Eligioo Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you want to use a different toolchain other than the current stable, you are supposed to get it by: dtolnay/[email protected].

The selection of Rust toolchain is made based on the particular @ rev of this Action being requested. For example "dtolnay/rust-toolchain@nightly" pulls in the nightly Rust toolchain, while "dtolnay/[email protected]" pulls in 1.42.0.

Important: the default is to match the @ rev as described above. When passing an explicit toolchain as an input instead of @ rev, you'll want to use "dtolnay/rust-toolchain@master" as the revision of the action.

Copy link
Member Author

@sisou sisou Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welp, it still works. If they want to enforce that, they should prevent the other ways from working :D

@jsdanielh jsdanielh added this to the Nimiq PoS Mainnet milestone Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to build npm (wasm) package in CI
3 participants