feat: Added segment synthesizer and provided ability to convert http client otel spans to external http trace segments #2745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…client otel spans to external http trace segments
bizob2828
force-pushed
the
otel-http-client-span-to-segment
branch
from
c18d106 to
e81adc9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2745 +/- ##
==========================================
- Coverage 97.30% 88.93% -8.38%
==========================================
Files 296 294 -2
Lines 46662 46486 -176
==========================================
- Hits 45404 41341 -4063
- Misses 1258 5145 +3887
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
bizob2828
added a commit
that referenced
this pull request
Nov 19, 2024
…client otel spans to external http trace segments (#2745)
bizob2828
added a commit
that referenced
this pull request
Nov 19, 2024
…client otel spans to external http trace segments (#2745)
bizob2828
added a commit
that referenced
this pull request
Dec 4, 2024
…client otel spans to external http trace segments (#2745)
bizob2828
added a commit
that referenced
this pull request
Dec 5, 2024
…client otel spans to external http trace segments (#2745)
bizob2828
added a commit
that referenced
this pull request
Dec 9, 2024
…client otel spans to external http trace segments (#2745)
bizob2828
added a commit
that referenced
this pull request
Dec 12, 2024
…client otel spans to external http trace segments (#2745)
bizob2828
added a commit
that referenced
this pull request
Dec 13, 2024
…client otel spans to external http trace segments (#2745)
bizob2828
added a commit
that referenced
this pull request
Dec 16, 2024
…client otel spans to external http trace segments (#2745)
bizob2828
added a commit
that referenced
this pull request
Dec 19, 2024
…client otel spans to external http trace segments (#2745)
bizob2828
added a commit
that referenced
this pull request
Jan 13, 2025
…client otel spans to external http trace segments (#2745)
bizob2828
added a commit
that referenced
this pull request
Jan 14, 2025
…client otel spans to external http trace segments (#2745)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds new keys to the rules.json(for now) to identity which type of segment should be created. I didn't enumerate all the types just yet. The intention is this will be called on the
onEnterSpansection of the otel tracer. Maybe we bind the relevant timeslice metric recorder but for now that's for a different story(#2654)Related Issues
Closes #2648