Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sourcery refactored master branch #31

Closed
wants to merge 1 commit into from
Closed

Conversation

sourcery-ai[bot]
Copy link

@sourcery-ai sourcery-ai bot commented Oct 16, 2020

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

@sourcery-ai sourcery-ai bot requested a review from neomatrix369 October 16, 2020 12:13
inJupyter = sys.argv[-1].endswith('json')
return inJupyter
return sys.argv[-1].endswith('json')
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function is_running_from_ipython refactored with the following changes:

  • Inline variable that is immediately returned (inline-immediately-returned-variable)

line = re.findall(r'[0-9]+', text)
return line
return re.findall(r'[0-9]+', text)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function gather_whole_numbers refactored with the following changes:

  • Inline variable that is immediately returned (inline-immediately-returned-variable)

score = score * 100
score *= 100
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function sentiment_polarity refactored with the following changes:

  • Replace assignment with augmented assignment (aug-assign)

Comment on lines -18 to -20
found_stop_words = [word for _, word in enumerate(word_tokens)
return [word for _, word in enumerate(word_tokens)
if word in STOP_WORDS]
return found_stop_words
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function gather_stop_words refactored with the following changes:

  • Inline variable that is immediately returned (inline-immediately-returned-variable)

for index in range(1):
for _ in range(1):
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function generate_data refactored with the following changes:

  • Replace unused for index with underscore (for-index-underscore)

for index in range(1):
for _ in range(1):
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function generate_data refactored with the following changes:

  • Replace unused for index with underscore (for-index-underscore)

@codecov-io
Copy link

codecov-io commented Oct 16, 2020

Codecov Report

Merging #31 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #31   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          358       355    -3     
  Branches        51        51           
=========================================
- Hits           358       355    -3     
Impacted Files Coverage Δ
nlp_profiler/generate_features.py 100.00% <100.00%> (ø)
nlp_profiler/numbers.py 100.00% <100.00%> (ø)
nlp_profiler/sentiment_polarity.py 100.00% <100.00%> (ø)
nlp_profiler/stop_words.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ad0271...5dd2f14. Read the comment docs.

Copy link
Owner

@neomatrix369 neomatrix369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neomatrix369 neomatrix369 deleted the sourcery/master branch October 16, 2020 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve code quality based on report from @sourcery-ai (generate_features.py)
2 participants