Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code quality based on report from @sourcery-ai (generate_features.py) #28

Open
neomatrix369 opened this issue Oct 16, 2020 · 0 comments · Fixed by #29, #30, #36 or #37
Open

Improve code quality based on report from @sourcery-ai (generate_features.py) #28

neomatrix369 opened this issue Oct 16, 2020 · 0 comments · Fixed by #29, #30, #36 or #37
Labels
2. medium-priority Good if it can be attended to be soon, but not urgent enough code-quality help wanted Extra attention is needed limitations

Comments

@neomatrix369
Copy link
Owner

neomatrix369 commented Oct 16, 2020 •
edited
Loading

Describe the limitations

As per the report from @sourcery-ai in #27 (comment) and #34 (comment)

Do the following:

  • reduce method length
  • make method(s), modules less complex (i.e. nlp_profiler/granular_features.py and other modules)
  • improve run-time working memory (maybe use memory-profiling)

Recommendation(s):

  • Extract out complex expressions
  • reduce working memory
@neomatrix369 neomatrix369 added help wanted Extra attention is needed 2. medium-priority Good if it can be attended to be soon, but not urgent enough limitations code-quality labels Oct 16, 2020
@neomatrix369 neomatrix369 changed the title Improve code quality based on report from @sourcery-ai Improve code quality based on report from @sourcery-ai (generate_features.py) Oct 16, 2020
@neomatrix369 neomatrix369 mentioned this issue Oct 16, 2020
Merged
@neomatrix369 neomatrix369 linked a pull request Oct 16, 2020 that will close this issue
Refactor: split the original generate_features.py module #29
Merged
@neomatrix369 neomatrix369 mentioned this issue Oct 16, 2020
Merged
This was linked to pull requests Oct 16, 2020
Sourcery refactored master branch #31
Closed
Sourcery refactored refactor-generate-features-module branch #30
Merged
@neomatrix369 neomatrix369 linked a pull request Oct 16, 2020 that will close this issue
Refactor: aggregating high-level features #34
Closed
@neomatrix369 neomatrix369 reopened this Oct 16, 2020
@neomatrix369 neomatrix369 mentioned this issue Oct 16, 2020
Closed
This was linked to pull requests Oct 16, 2020
Sourcery refactored master branch #33
Closed
Sourcery refactored master branch #36
Merged
Refactor high level features #37
Merged
@neomatrix369 neomatrix369 reopened this Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2. medium-priority Good if it can be attended to be soon, but not urgent enough code-quality help wanted Extra attention is needed limitations
Projects
None yet
Milestone
No milestone
1 participant
@neomatrix369