-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: split the original generate_features.py module #29
Conversation
…allelisation aspect into a module of it's own
@sourcery-ai in the above report it would be helpful to find out what those recommended/suggested changes are, which areas in the code these changes can be brought about The before and after changes report/comparison maybe a bit counter-intuitive if compared to the changes made in the code base |
… into python packages
Sourcery Code Quality ReportThis PR has an average code quality of 85.18%
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Let us know what you think of it by mentioning @sourcery-ai in a comment. |
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 21 +1
Lines 358 360 +2
Branches 51 51
=========================================
+ Hits 358 360 +2
Continue to review full report at Codecov.
|
Merging, for now, will use the @sourcery-ai generated PRs as guidance to refractor further |
Refactor: split the original generate_features.py and extract the parallelisation aspect into a module of it's own
Related to issue #28, and partially resolves it (reduces complexity)