-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mer beskrivende dokumentbeskrivelse #618
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,22 @@ | ||
package no.nav.syfo.domain | ||
|
||
import java.time.LocalDate | ||
import java.time.format.DateTimeFormatter | ||
|
||
data class Periode( | ||
val fom: LocalDate, | ||
val tom: LocalDate, | ||
) | ||
|
||
val norskDatoFormat: DateTimeFormatter = DateTimeFormatter.ofPattern("dd.MM.yyyy") | ||
|
||
fun LocalDate.tilNorskFormat(): String = format(norskDatoFormat) | ||
|
||
fun List<Periode>.tilKortFormat(emptyArrayString: String): String = | ||
if (isEmpty()) { | ||
emptyArrayString | ||
} else if (size < 2) { | ||
"${first().fom.tilNorskFormat()} - ${first().tom.tilNorskFormat()}" | ||
} else { | ||
"${first().fom.tilNorskFormat()} - [...] - ${last().tom.tilNorskFormat()}" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
src/main/kotlin/no/nav/syfo/util/DokumentbeskrivelseUtils.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
package no.nav.syfo.util | ||
|
||
import no.nav.syfo.domain.inntektsmelding.Inntektsmelding | ||
import no.nav.syfo.domain.tilKortFormat | ||
|
||
fun Inntektsmelding.tilDokumentbeskrivelse(): String { | ||
val orgnr = this.arbeidsgiverOrgnummer.let { if (it.isNullOrBlank()) "(ingen orgnr)" else it } | ||
val agp = this.arbeidsgiverperioder.tilKortFormat("(ingen agp)") | ||
return "Inntektsmelding-$orgnr-$agp" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
src/test/kotlin/no/nav/syfo/util/DokumentbeskrivelseUtilsTest.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
package no.nav.syfo.util | ||
|
||
import no.nav.syfo.grunnleggendeInntektsmelding | ||
import org.assertj.core.api.Assertions.assertThat | ||
import org.junit.jupiter.api.Test | ||
|
||
class DokumentbeskrivelseUtilsTest { | ||
@Test | ||
fun `1 agp i dokumentbeskrivelse`() { | ||
assertThat(grunnleggendeInntektsmelding.tilDokumentbeskrivelse()) | ||
.isEqualTo("Inntektsmelding-1234-01.01.2019 - 01.02.2019") | ||
} | ||
|
||
@Test | ||
fun `2 agp i dokumentbeskrivelse`() { | ||
val periode = grunnleggendeInntektsmelding.arbeidsgiverperioder.first() | ||
assertThat(grunnleggendeInntektsmelding.copy(arbeidsgiverperioder = listOf(periode, periode)).tilDokumentbeskrivelse()) | ||
.isEqualTo("Inntektsmelding-1234-01.01.2019 - [...] - 01.02.2019") | ||
} | ||
|
||
@Test | ||
fun `ingen agp i dokumentbeskrivelse`() { | ||
assertThat(grunnleggendeInntektsmelding.copy(arbeidsgiverperioder = emptyList()).tilDokumentbeskrivelse()) | ||
.isEqualTo("Inntektsmelding-1234-(ingen agp)") | ||
} | ||
|
||
@Test | ||
fun `ingen orgnr i dokumentbeskrivelse`() { | ||
assertThat(grunnleggendeInntektsmelding.copy(arbeidsgiverOrgnummer = null).tilDokumentbeskrivelse()) | ||
.isEqualTo("Inntektsmelding-(ingen orgnr)-01.01.2019 - 01.02.2019") | ||
} | ||
|
||
@Test | ||
fun `tom string orgnr i dokumentbeskrivelse`() { | ||
assertThat(grunnleggendeInntektsmelding.copy(arbeidsgiverOrgnummer = "").tilDokumentbeskrivelse()) | ||
.isEqualTo("Inntektsmelding-(ingen orgnr)-01.01.2019 - 01.02.2019") | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
emptyArrayString høres litt ut som en String som beskriver en tom array.. Kan det kanskje være fallbackverdiHvisManglerPeriode eller defaultHvisTom eller noe slikt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jeg ville returnert
null
ved tom liste, så defaulte der funksjonen kalles.