Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mer beskrivende dokumentbeskrivelse #618

Merged
merged 4 commits into from
Jan 21, 2025
Merged

Conversation

Jesper-Hustad
Copy link
Contributor

Lagt til orgnr og arbeidsgiverperiode i dokumentbeskrivelsen.

@Jesper-Hustad Jesper-Hustad requested a review from a team as a code owner January 20, 2025 15:30
@Jesper-Hustad
Copy link
Contributor Author

Testet i dev:
image

@b162214 b162214 requested a review from mortenbyhring January 21, 2025 08:45

fun LocalDate.tilNorskFormat(): String = format(norskDatoFormat)

fun List<Periode>.tilKortFormat(emptyArrayString: String): String =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emptyArrayString høres litt ut som en String som beskriver en tom array.. Kan det kanskje være fallbackverdiHvisManglerPeriode eller defaultHvisTom eller noe slikt?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeg ville returnert null ved tom liste, så defaulte der funksjonen kalles.

@Jesper-Hustad Jesper-Hustad merged commit d04a01a into master Jan 21, 2025
4 checks passed
@Jesper-Hustad Jesper-Hustad deleted the dev/dokumentbeskrivelse branch January 21, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants