Equity maps; various other UI enhancements #141
Conversation
davemfish
commented
Sep 6, 2024
•
davemfish
commented
- Added layers displaying bivariate equity variables: heat-income and heat-race.
- Added a new landing page displaying this layer, its legend, and some text descriptions of the application
- Added some state to control which map layers are displayed when, including better defaults for first-time visitors & return visitors
- Various other style cleanup
- Various bugfixes with interactions in the study area table, etc
There was a problem hiding this comment.
Thanks @davemfish, I had a few questions and comments. I know we're kind of playing these fast and loose a bit, so let me know what you think the right level of review is here. It was hard to have a full understanding without seeing the workflow in person / having screenshots.
| const [servicesheds, setServicesheds] = useState({}); | ||
| const [activeTab, setActiveTab] = useState('explore'); | ||
| const [start, setStart] = useState(0); |
There was a problem hiding this comment.
Tracking if the "Get Started" button was clicked.
frontend/src/edit/edit.jsx
Outdated
| } = props; | ||
|
|
||
| const [activeTab, setActiveTab] = useState('scenarios'); | ||
| // const [activeTab, setActiveTab] = useState('explore'); |
There was a problem hiding this comment.
Looks like this was up into App.jsx
| @@ -67,10 +71,18 @@ export default function App() { | |||
| setPatternSamplingMode((mode) => !mode); | |||
| }; | |||
|
|
|||
| const startBuilding = () => { | |||
There was a problem hiding this comment.
Could be useful to have a docstring / comment for the purpose of this function.
| @@ -5,6 +5,7 @@ import { | |||
| InputGroup, | |||
| Radio, | |||
| RadioGroup, | |||
| Section, | |||
There was a problem hiding this comment.
This was added, but does it get used?
| }, | ||
| ); | ||
| }; | ||
|
|
||
| useEffect(() => { | ||
| const center = [-10968819.475036152, 3423289.328458109]; | ||
| if (start) { |
There was a problem hiding this comment.
Okay, so start is driving the "walkthrough" animations?
| @@ -345,6 +409,7 @@ export default function MapComponent(props) { | |||
| ); | |||
|
|
|||
| map.on(['click'], async (event) => { | |||
| // console.log(map.getCoordinateFromPixel(event.pixel)); | |||
There was a problem hiding this comment.
I thought it is somewhat likely I will want to use this again in the future, so decided to leave it in for convenience.
Yeah I completely agree. Don't feel like you need to devote too much time. And feel free to pull the fork and try it out! Good idea to add some comments and clean things up. I pushed some changes. |
