Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing colormap file & equity geojson #143

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

davemfish
Copy link
Contributor

@davemfish davemfish commented Sep 12, 2024

Adding a file that was missed in #141

And loading a geojson from GCS instead of from a local file.

Fixed a failing test where some conditional rendering was previously only working by coincidence.

Fixed a bug in the firstVisit state that would prevent someone from switching from Results to Scenarios during their first session.

@davemfish davemfish changed the base branch from main to develop September 12, 2024 18:11
@davemfish davemfish marked this pull request as draft September 12, 2024 18:14
@davemfish davemfish changed the title Bugfix/missing colormap file missing colormap file & equity geojson Sep 12, 2024
@davemfish davemfish marked this pull request as ready for review September 12, 2024 19:34
@davemfish davemfish requested a review from dcdenu4 September 12, 2024 19:34
Copy link
Member

@dcdenu4 dcdenu4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for this Dave!

@dcdenu4 dcdenu4 merged commit 77ec6e8 into natcap:develop Sep 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants