Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUBSCRIBEs end at a group boundary #593

Merged
merged 1 commit into from
Oct 26, 2024
Merged

SUBSCRIBEs end at a group boundary #593

merged 1 commit into from
Oct 26, 2024
+6 −14

Conversation

ianswett
Copy link
Collaborator

This is a dependency of Martin's Stream FIN/RESET PR, #589

@ianswett
SUBSCRIBEs end at a group boundary
584ffab 
This is a dependency of Martin's Stream FIN/RESET PR, #589
@ianswett ianswett added the Subscribe Related to SUBSCRIBE message and subscription handling label Oct 22, 2024
@ianswett ianswett requested a review from martinduke October 22, 2024 18:26
@ianswett ianswett mentioned this pull request Oct 22, 2024
Merged
martinduke
martinduke approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@martinduke martinduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the fact that this simplifies the FIN logic, I really like that this frees the subscriber from either finding out the last object or sending object ID 2^62-1.

@ianswett ianswett merged commit b036eb8 into main Oct 26, 2024
2 checks passed
This was referenced Feb 25, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinduke martinduke martinduke approved these changes

Assignees
No one assigned
Labels
Subscribe Related to SUBSCRIBE message and subscription handling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianswett @martinduke