[MRG] Adds Sources for scans.tsv files

[adam2392]

PR Description

Fixes: #887

Waiting on: bids-standard/bids-specification#906

Merge checklist

Maintainer, please confirm the following before merging:

• All comments resolved
• This is not your own PR
• All CIs are happy
• PR title starts with [MRG]
• whats_new.rst is updated
• PR description includes phrase "closes <#issue-number>"

[adam2392]

@sappelhoff does the bids-validator prevent a Sources key value in the sidecar JSONs?

[sappelhoff]

@sappelhoff does the bids-validator prevent a Sources key value in the sidecar JSONs?

yes --> https://github.com/bids-standard/bids-validator/blob/682d44048d10b2d027125cadddc4d378060b0eea/bids-validator/validators/json/schemas/eeg.json#L44

I would recommend with PRs until the BIDS side is done, else you might end up investing too much effort

[adam2392]

Validator PR: https://github.com/bids-standard/bids-validator/pull/1374

[adam2392]

Now CIs should fully pass with the latest addition to only write lower-case EDF

[codecov]

Codecov Report

Merging #890 (9231e6b) into main (72ce6f1) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #890      +/-   ##
==========================================
+ Coverage   94.73%   94.78%   +0.04%     
==========================================
  Files          23       23              
  Lines        3460     3487      +27     
==========================================
+ Hits         3278     3305      +27     
  Misses        182      182              

Impacted Files	Coverage Δ
mne_bids/copyfiles.py	98.07% <100.00%> (ø)
mne_bids/utils.py	96.41% <100.00%> (+0.01%)	⬆️
mne_bids/write.py	96.22% <100.00%> (+0.09%)	⬆️
mne_bids/path.py	97.50% <0.00%> (+0.01%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72ce6f1...9231e6b. Read the comment docs.

[hoechenberger]

Is there a specific reason why the column name is plural ("sources") and not singular?

[adam2392]

Is there a specific reason why the column name is plural ("sources") and not singular?

Good point. I was keeping in line with Sources BIDS nomenclature, but that's a different meaning technically. I'll adjust to singular.

[hoechenberger]

Otherwise LGTM!

[adam2392]

@sappelhoff lmk if this good to merge?

[hoechenberger]

Two tiny nitpicks

[hoechenberger]

Thank you, @adam2392!!

[sappelhoff]

Thanks adam :)