-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding sourcedata filename to a column in the scans.tsv file #905
Comments
Definitely can't do a must, and for PHI reasons (and the fact that scans.tsv is optional) I think should is too strong. This does seem okay to put in as may. An alternative could be promoting the derivative Sources metadata to raw files as well. |
You mean https://bids-specification.readthedocs.io/en/stable/05-derivatives/02-common-data-types.html here? I suppose that serves the same purpose as adding I'm okay w/ either option as long as it's specified in BIDS, then we can support it in |
+1 to using |
Yes.
Yes. Another approach to this could just be a table in |
Also +1 to make |
Should this just go in the sidecar json part for each MEG, EEG and iEEG? |
Same for me |
I would be careful of including original filenames inside the BIDS dataset, since many times they could contain sensitive data (eg. surnames, real dates, diseases, etc). Since this is not imprescindible information to understand the dataset itself, but lab management logistics. I would incline more towards some log outside (eg in /sourcedata), that one can easily delete before the dataset is shared. Having a field inside a json or tsv might be more difficult to delete. |
yup we raised that concern in the PR: #906 (comment) Though technically nothing in BIDS prevents from naming a file: |
closed, because we discussed in #906 that implementing this on the tooling side of things would suffice ... see mne-tools/mne-bids#890 |
Problem
I've been working with conversion of
sourcedata
files over to BIDS for the sake of i) speeding up my analysis work streams and ii) speeding up sharing of datasets. However, many times you'll have new datasets coming in, or maybe you want to determine if the file you uploaded with some filename (e.g.subject001_eeg_001.edf
) was converted or not.Moreover, many of my collaborators (i.e. clinicians) only remember their original file naming scheme, not the organized BIDS files. Unfortunately, then there's a lot of back and forth about which file is which unless there is a backwards trace of which BIDS file corresponds to which source file. There is no easy way to check this right now.
Suggestion
My proposal is to add a SHOULD requirement in the
scans.tsv
that suggests that users add a column to the file fororiginal_filename
, which adds the filename of the source file. This way, one can backtrack what was converted easily. To be honest, I think it should be a MUST, unless there is some sort of PHI embedded in the source filename?The text was updated successfully, but these errors were encountered: