Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename invalid response error #247

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Rename invalid response error #247

merged 2 commits into from
Dec 4, 2023

Conversation

mat-sop
Copy link
Contributor

@mat-sop mat-sop commented Dec 4, 2023

This pr renames GraphQlClientInvalidResponseError to GraphQLClientInvalidResponseError (with capitalized L, as rest of exceptions in exceptions.py)

resolve #238

@mat-sop mat-sop self-assigned this Dec 4, 2023
@mat-sop mat-sop requested a review from rafalp December 4, 2023 13:29
@mat-sop mat-sop merged commit 79ad7fc into main Dec 4, 2023
4 checks passed
@mat-sop mat-sop deleted the rename_invalid_response_error branch December 4, 2023 13:35
@twavv
Copy link

twavv commented Jan 4, 2024

Thanks for being so responsive on this! It's appreciated greatly. 💖😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafalp rafalp rafalp approved these changes

Assignees

@mat-sop mat-sop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GraphQlClientInvalidResponseError has inconsistent casing
3 participants
@mat-sop @twavv @rafalp